Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v-model changes to migration guide #143

Merged
merged 8 commits into from
Jul 13, 2020
Merged

Add v-model changes to migration guide #143

merged 8 commits into from
Jul 13, 2020

Conversation

NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented Jul 12, 2020 •
edited
Loading

  • Added a new section for v-model changes and .sync modifier removal
  • Added sections for migration 'impact (i.e. 'Critical', 'High' etc)

Rendered preview

@NataliaTepluhina NataliaTepluhina self-assigned this Jul 12, 2020
@NataliaTepluhina NataliaTepluhina added this to the alpha milestone Jul 12, 2020
@NataliaTepluhina NataliaTepluhina linked an issue Jul 12, 2020 that may be closed by this pull request
Create custom component's v-model changes chapter on Migration Guide #142
Closed
phanan
phanan reviewed Jul 12, 2020
View reviewed changes
bencodezen
bencodezen approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @NataliaTepluhina! Nothing blocking as far as changes, so feel free to merge whenever you decide!

@bencodezen bencodezen mentioned this pull request Jul 13, 2020
Closed
25 tasks
@phanan
Copy link
Member

phanan commented Jul 13, 2020

No please don't merge. I'll be that guy here again. Let's discuss the "Critical" part first.

@NataliaTepluhina
Copy link
Member Author

@phanan @bencodezen I've removed the 'categorization' to Critical/High/etc and refactored v-model changes a bit to include @sdras previous work on Migration guide. Could you please take a second look? 🙏

bencodezen
bencodezen approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two small suggestions based on our discussion about deprecated vs breaking and a small diction choice alternative.

Otherwise, great job on taking the docs on this to the next level! 🎉

@NataliaTepluhina NataliaTepluhina merged commit cc0673f into master Jul 13, 2020
@NataliaTepluhina NataliaTepluhina deleted the v-model-migration branch July 15, 2020 09:15
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
@starryeve
fix(custom-directives.md): fix typo (vuejs#143)
140a013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencodezen bencodezen bencodezen approved these changes

@sdras sdras Awaiting requested review from sdras

@phanan phanan Awaiting requested review from phanan

Assignees

@NataliaTepluhina NataliaTepluhina

Labels
None yet
Projects
None yet
Milestone
alpha
Development

Successfully merging this pull request may close these issues.

Create custom component's v-model changes chapter on Migration Guide
3 participants
@NataliaTepluhina @phanan @bencodezen