Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 5 brakes linter #691

Closed
Piterden opened this issue Dec 1, 2018 · 11 comments
Closed

Beta 5 brakes linter #691

Piterden opened this issue Dec 1, 2018 · 11 comments

Comments

@Piterden
Copy link

Piterden commented Dec 1, 2018

Beta 5 shows many errors. Looks like it not read the config file. Beta 4 is fine.

@mysticatea
Copy link
Member

Hi. Please open an issue with our issue template. We cannot investigate problems if there are no reproduce.

@Piterden
Copy link
Author

Piterden commented Dec 1, 2018

@mysticatea
Copy link
Member

Would you fill our issue template?
That video shows actual errors but it's not enough to reproduce it because it doesn't show configs and source codes.

@mysticatea mysticatea reopened this Dec 1, 2018
@Piterden
Copy link
Author

Piterden commented Dec 1, 2018

https://github.com/Piterden/vue-crossword

https://codesandbox.io/s/github/Piterden/vue-crossword/tree/master/

den:~/projects/vue-crossword (master M) $ node -v
v10.9.0
den:~/projects/vue-crossword (master M) $ npm -v
6.4.1

@armano2
Copy link
Contributor

armano2 commented Dec 1, 2018

in beta.5 we enabled additional rules

@Piterden
Copy link
Author

Piterden commented Dec 1, 2018

It broke our staging build

@mysticatea
Copy link
Member

Thank you.

You have plugin:vue/recommended in your config, so this is expected behavior.
We have updated the recommended config in that version.

We don't change the recommended config without major version up, but we did in beta.

@Piterden
Copy link
Author

Piterden commented Dec 1, 2018

Thank you for the explanation @mysticatea and @armano2 . Now it is clear enough.

@armano2
Copy link
Contributor

armano2 commented Dec 1, 2018

✖ 16 problems (2 errors, 14 warnings)
0 errors and 14 warnings potentially fixable with the --fix option.

@Piterden
Copy link
Author

Piterden commented Dec 1, 2018

vue/component-name-in-template-casing provides React style of component names. It is strongly recommended to use kebab-cased names.

@mysticatea
Copy link
Member

I agree with you. I like kebab-case than PascalCase strongly because HTML is case-insensitive. However, the team seems to have a different preference. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants