feat: name --max-warnings to --max-errors, add --max-warnings

Author: jkzing

packages/@vue/cli-plugin-eslint/index.js

@@ -25,7 +25,8 @@ module.exports = (api, { lintOnSave }) => {
     options: {
       '--format [formatter]': 'specify formatter (default: codeframe)',
       '--no-fix': 'do not fix errors',
-      '--max-warnings [limit]': 'specify number of warnings to make build failed'
+      '--max-errors [limit]': 'specify number of errors to make build failed (default: 0)',
+      '--max-warnings [limit]': 'specify number of warnings to make build failed (default: Infinity)'
     },
     details: 'For more options, see https://eslint.org/docs/user-guide/command-line-interface#options'
   }, args => {

packages/@vue/cli-plugin-eslint/lint.js

@@ -20,7 +20,10 @@ module.exports = function lint (args = {}, api) {
     CLIEngine.outputFixes(report)
   }
 
-  if (report.errorCount <= (argsConfig.maxWarnings || 0)) {
+  const isErrorsExceed = report.errorCount > (argsConfig.maxErrors || 0)
+  const isWarningsExceed = report.warningCount > (
+    'maxWarnings' in argsConfig ? argsConfig.maxWarnings : Infinity)
+  if (!isErrorsExceed && !isWarningsExceed) {
     if (!args.silent) {
       const hasFixed = report.results.some(f => f.output)
       if (hasFixed) {
@@ -41,6 +44,12 @@ module.exports = function lint (args = {}, api) {
     }
   } else {
     console.log(formatter(report.results))
+    if (isErrorsExceed && typeof argsConfig.maxErrors === 'number') {
+      log(`Eslint found too many errors (maximum: ${argsConfig.maxErrors}).`)
+    }
+    if (isWarningsExceed) {
+      log(`Eslint found too many warnings (maximum: ${argsConfig.maxWarnings}).`)
+    }
     process.exit(1)
   }
 }