Skip to content

Commit 460c200

Browse files
committed
fix(unit-mocha): node externals are unnecessary for testing client code
close #1548
1 parent 9e0a393 commit 460c200

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

packages/@vue/cli-plugin-unit-mocha/index.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@ module.exports = api => {
33
if (process.env.NODE_ENV === 'test') {
44
webpackConfig.merge({
55
target: 'node',
6-
devtool: 'inline-cheap-module-source-map',
7-
externals: [
8-
require('webpack-node-externals')(),
9-
'vue-server-renderer'
10-
]
6+
devtool: 'inline-cheap-module-source-map'
117
})
128

139
// when target === 'node', vue-loader will attempt to generate

packages/@vue/cli-plugin-unit-mocha/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
"jsdom": "^11.10.0",
2626
"jsdom-global": "^3.0.2",
2727
"mocha": "^5.1.1",
28-
"mocha-webpack": "^2.0.0-beta.0",
29-
"webpack-node-externals": "^1.7.2"
28+
"mocha-webpack": "^2.0.0-beta.0"
3029
},
3130
"devDependencies": {
3231
"@vue/test-utils": "^1.0.0-beta.16",

0 commit comments

Comments
 (0)