Skip to content

Commit 89a0e65

Browse files
committed
fix: avoid util.promisify when resolving webpack.config.js
The file may be required by an IDE which uses an older version of Node. close #1473
1 parent 98b6d26 commit 89a0e65

File tree

5 files changed

+4
-5
lines changed

5 files changed

+4
-5
lines changed

packages/@vue/cli-shared-utils/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,3 @@
1414

1515
exports.chalk = require('chalk')
1616
exports.execa = require('execa')
17-
exports.cmdShim = require('util').promisify(require('cmd-shim'))

packages/@vue/cli-shared-utils/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"homepage": "https://github.com/vuejs/vue-cli/packages/@vue/cli-shared-utils#readme",
2121
"dependencies": {
2222
"chalk": "^2.3.0",
23-
"cmd-shim": "^2.0.2",
2423
"execa": "^0.10.0",
2524
"joi": "^12.0.0",
2625
"node-ipc": "^9.1.1",

packages/@vue/cli/lib/Creator.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ const { clearConsole } = require('./util/clearConsole')
1414
const PromptModuleAPI = require('./PromptModuleAPI')
1515
const writeFileTree = require('./util/writeFileTree')
1616
const { formatFeatures } = require('./util/features')
17-
const setupDevProject = require('./util/setupDevProject')
1817
const fetchRemotePreset = require('./util/fetchRemotePreset')
1918

2019
const {
@@ -134,7 +133,7 @@ module.exports = class Creator extends EventEmitter {
134133
this.emit('creation', { event: 'plugins-install' })
135134
if (isTestOrDebug) {
136135
// in development, avoid installation process
137-
await setupDevProject(context)
136+
await require('./util/setupDevProject')(context)
138137
} else {
139138
await installDeps(context, packageManager, cliOptions.registry)
140139
}

packages/@vue/cli/lib/util/linkBin.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
// cross-platform executable link, mostly for Windows
2+
// this file is dev-only.
23

34
const fs = require('fs-extra')
45
const path = require('path')
5-
const { cmdShim } = require('@vue/cli-shared-utils')
6+
const cmdShim = require('util').promisify(require('cmd-shim'))
67

78
exports.linkBin = async (src, dest) => {
89
if (!process.env.VUE_CLI_TEST && !process.env.VUE_CLI_DEBUG) {

packages/@vue/cli/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"@vue/cli-ui": "^3.0.0-beta.15",
3232
"@vue/cli-ui-addon-webpack": "^3.0.0-beta.15",
3333
"chalk": "^2.3.0",
34+
"cmd-shim": "^2.0.2",
3435
"commander": "^2.12.2",
3536
"debug": "^3.1.0",
3637
"deepmerge": "^2.0.1",

0 commit comments

Comments
 (0)