Skip to content

Commit c2583e4

Browse files
committed
feat: move babel-preset and eslint-plugin as deps of plugins
1 parent 2d6a0d9 commit c2583e4

File tree

9 files changed

+5
-18
lines changed

9 files changed

+5
-18
lines changed

packages/@vue/cli-plugin-babel/generator.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
module.exports = api => {
22
api.extendPackage({
3-
devDependencies: {
4-
'@vue/babel-preset-app': '^3.0.0-alpha.3'
5-
},
63
babel: {
74
presets: ['@vue/app']
85
}

packages/@vue/cli-plugin-babel/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
"homepage": "https://github.com/vuejs/vue-cli/packages/@vue/cli-plugin-babel#readme",
2121
"dependencies": {
2222
"@babel/core": "^7.0.0-0",
23-
"babel-loader": "^8.0.0-0",
24-
"cache-loader": "^1.2.0"
23+
"@vue/babel-preset-app": "^3.0.0-alpha.3",
24+
"babel-loader": "^8.0.0-0"
2525
},
2626
"publishConfig": {
2727
"access": "public"

packages/@vue/cli-plugin-eslint/__tests__/eslintGenerator.spec.js

-4
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ test('base', async () => {
1111
expect(pkg.eslintConfig).toEqual({
1212
extends: ['plugin:vue/essential', 'eslint:recommended']
1313
})
14-
expect(pkg.devDependencies).toHaveProperty('eslint-plugin-vue')
1514
})
1615

1716
test('airbnb', async () => {
@@ -27,7 +26,6 @@ test('airbnb', async () => {
2726
expect(pkg.eslintConfig).toEqual({
2827
extends: ['plugin:vue/essential', '@vue/airbnb']
2928
})
30-
expect(pkg.devDependencies).toHaveProperty('eslint-plugin-vue')
3129
expect(pkg.devDependencies).toHaveProperty('@vue/eslint-config-airbnb')
3230
})
3331

@@ -44,7 +42,6 @@ test('standard', async () => {
4442
expect(pkg.eslintConfig).toEqual({
4543
extends: ['plugin:vue/essential', '@vue/standard']
4644
})
47-
expect(pkg.devDependencies).toHaveProperty('eslint-plugin-vue')
4845
expect(pkg.devDependencies).toHaveProperty('@vue/eslint-config-standard')
4946
})
5047

@@ -61,7 +58,6 @@ test('prettier', async () => {
6158
expect(pkg.eslintConfig).toEqual({
6259
extends: ['plugin:vue/essential', '@vue/prettier']
6360
})
64-
expect(pkg.devDependencies).toHaveProperty('eslint-plugin-vue')
6561
expect(pkg.devDependencies).toHaveProperty('@vue/eslint-config-prettier')
6662
})
6763

packages/@vue/cli-plugin-eslint/generator.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@ module.exports = (api, { config, lintOn = [] }) => {
1010
eslintConfig: {
1111
extends: ['plugin:vue/essential']
1212
},
13-
devDependencies: {
14-
'eslint-plugin-vue': '^4.2.0'
15-
}
13+
devDependencies: {}
1614
}
1715

1816
if (config === 'airbnb') {

packages/@vue/cli-plugin-eslint/package.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@
2424
"dependencies": {
2525
"babel-eslint": "^8.2.1",
2626
"eslint": "^4.16.0",
27-
"eslint-loader": "^1.9.0"
28-
},
29-
"devDependencies": {
27+
"eslint-loader": "^1.9.0",
3028
"eslint-plugin-vue": "^4.0.0"
3129
}
3230
}

packages/@vue/cli-plugin-typescript/__tests__/tsGenerator.spec.js

-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ test('use with Babel', async () => {
5555
}
5656
])
5757

58-
expect(pkg.devDependencies).toHaveProperty('@vue/babel-preset-app')
5958
expect(pkg.babel).toEqual({ presets: ['@vue/app'] })
6059
expect(files['tsconfig.json']).toMatch(`"target": "es2015"`)
6160
})

packages/@vue/cli-plugin-typescript/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
},
2424
"dependencies": {
2525
"@types/node": "^9.3.0",
26-
"cache-loader": "^1.2.0",
2726
"fork-ts-checker-webpack-plugin": "^0.3.0",
2827
"globby": "^7.1.1",
2928
"ts-loader": "^3.3.1",

packages/@vue/cli-service/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"address": "^1.0.3",
2727
"autodll-webpack-plugin": "^0.3.8",
2828
"autoprefixer": "^7.2.5",
29+
"cache-loader": "^1.2.0",
2930
"case-sensitive-paths-webpack-plugin": "^2.1.1",
3031
"chalk": "^2.3.0",
3132
"copy-webpack-plugin": "^4.3.1",

packages/@vue/cli/__tests__/invoke.spec.js

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ test('invoke single generator', async () => {
1717

1818
const updatedPkg = JSON.parse(await project.read('package.json'))
1919
expect(updatedPkg.scripts.lint).toBe('vue-cli-service lint')
20-
expect(updatedPkg.devDependencies).toHaveProperty('eslint-plugin-vue')
2120
expect(updatedPkg.devDependencies).toHaveProperty('lint-staged')
2221
expect(updatedPkg.eslintConfig).toEqual({
2322
extends: ['plugin:vue/essential', '@vue/airbnb']

0 commit comments

Comments
 (0)