fix(ui): Suggestions API fixes

Author: Guillaume Chau

packages/@vue/cli-ui/src/components/SuggestionBar.vue

@@ -5,12 +5,18 @@
   >
     <ApolloSubscribeToMore
       :document="require('../graphql/suggestionAdded.gql')"
-      :updateQuery="(previousResult, { subscriptionData }) => ({
-        suggestions: [
-          ...previousResult.suggestions,
-          subscriptionData.data.suggestionAdded
-        ]
-      })"
+      :updateQuery="(previousResult, { subscriptionData }) => {
+        const newSuggestion = subscriptionData.data.suggestionAdded
+        if (previousResult.suggestions.find(s => s.id === newSuggestion.id)) {
+          return previousResult
+        }
+        return {
+          suggestions: [
+            ...previousResult.suggestions,
+            newSuggestion
+          ]
+        }
+      }"
     />
 
     <ApolloSubscribeToMore

packages/@vue/cli-ui/src/graphql-api/connectors/suggestions.js

@@ -1,5 +1,7 @@
 // Subs
 const channels = require('../channels')
+// Connectors
+const { log } = require('../utils/logger')
 
 const suggestions = []
 
@@ -25,18 +27,23 @@ function add (suggestion, context) {
     suggestionAdded: suggestion
   })
 
+  log('Suggestion added', suggestion.id)
+
   return suggestion
 }
 
 function remove (id, context) {
   const suggestion = findOne(id)
+  if (!suggestion) return
   const index = suggestions.indexOf(suggestion)
   suggestions.splice(index, 1)
 
   context.pubsub.publish(channels.SUGGESTION_REMOVED, {
     suggestionRemoved: suggestion
   })
 
+  log('Suggestion removed', suggestion.id)
+
   return suggestion
 }
 
@@ -55,6 +62,8 @@ function update (data, context) {
     suggestionUpdated: suggestion
   })
 
+  log('Suggestion updated', suggestion.id)
+
   return suggestion
 }