Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint plugin does not support --max-warnings option #1268

Closed
BenoitAverty opened this issue May 11, 2018 · 3 comments
Closed

eslint plugin does not support --max-warnings option #1268

BenoitAverty opened this issue May 11, 2018 · 3 comments

Comments

@BenoitAverty
Copy link

What problem does this feature solve?

ESLint has a --max-warnings command line options that triggers an return code > 0 when eslint detects more than n warnings.

This is really useful for example to allow developpers to work without worrying about eslint warnings, but make the CI build fail if there are some warnings.

Since @vue/cli-plugin-eslint uses eslint's CLIEngine instead of the cli object, this option is not supported (it is handled by cli.js, not cli-engine.js). It would be nice to have this feature in vue cli, either by re-implementing it, or by using the cli.js script of eslint.

What does the proposed API look like?

vue-cli-service lint --max-warnings=0

@posva
Copy link
Member

posva commented May 11, 2018

Duplicate of #1255

@posva posva marked this as a duplicate of #1255 May 11, 2018
@posva posva closed this as completed May 11, 2018
@BenoitAverty
Copy link
Author

@posva Is it really a duplicate though ? The issue you linked seems to be about passing arguments to cli engine. This wouldn't solve this. Unless it's a broader issue ? What is the preferred way to cover my specific use case ? Reimplement the functionality or switch to using cli.js ?

@posva
Copy link
Member

posva commented May 11, 2018

oh true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants