Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0-beta.10 breaks postcss #1285

Closed
doublemarked opened this issue May 14, 2018 · 7 comments
Closed

3.0.0-beta.10 breaks postcss #1285

doublemarked opened this issue May 14, 2018 · 7 comments

Comments

@doublemarked
Copy link

doublemarked commented May 14, 2018

Version

3.0.0-beta.10

Reproduction link

https://github.com/doublemarked/broken-lang-postcss

Steps to reproduce

  1. Use postcss in a style block within a .vue file, with or without lang="postcss". For example,
<style>
  .container {
     color: black;
     & .inner {
        color: red;
     }
  }
</style>
<!-- or -->
<style lang="postcss">
  .container {
     color: black;
     & .inner {
        color: red;
     }
  }
</style>

What is expected?

PostCSS should be supported out of the box, as it was with the previous version. The documentation still implies that it's enabled by default.

What is actually happening?

  1. When no "lang" is specified, PostCSS is ignored (treated as normal CSS).
  2. With lang="postcss" it's breaking the build with an error such as,
 error  in ./src/App.vue?vue&type=style&index=0&lang=postcss

Module parse failed: Unexpected character '#' (13:0)
You may need an appropriate loader to handle this file type.
| 
| 
| #app {
...

This worked fine until I upgraded from beta 9 to beta 10.

@doublemarked
Copy link
Author

doublemarked commented May 14, 2018

Hey @LinusBorg - I see you labeled this discussion. Does that mean it's working as intended? At least seems like the docs should be clarified?

@doublemarked doublemarked changed the title postcss broken 3.0.0-beta.10 breaks postcss May 14, 2018
@LinusBorg
Copy link
Member

It means that I'm not sure what we should do with it right now.

@yyx990803
Copy link
Member

yyx990803 commented May 14, 2018

FYI <style lang="postcss"> was never supposed to work. See #1259

@yyx990803 yyx990803 reopened this May 14, 2018
@yyx990803
Copy link
Member

Without lang="postcss" it's working as intended.

@doublemarked
Copy link
Author

That makes sense. But actually all my code uses the lang attribute, and the build breaks after the upgrade. Is that also as intended?

@yyx990803
Copy link
Member

beta 10 has breaking changes due to vue-loader upgrades.

@doublemarked
Copy link
Author

doublemarked commented May 14, 2018

Ok, no problem! Thank you for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants