Add a --copy option to the serve command #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts? |
jkzing
reviewed
May 27, 2018
docs/config.md
Outdated
| @@ -66,6 +66,7 @@ module.exports = { | |||
| // configure webpack-dev-server behavior | |||
| devServer: { | |||
| open: process.platform === 'darwin', | |||
| copy: false, | |||
There was a problem hiding this comment.
devServer is used to configure webpack-dev-server, I don't think adding a non webpack-dev-server option here is a good idea.
yyx990803
requested changes
May 29, 2018
| @@ -10,12 +10,15 @@ const defaults = { | |||
| https: false | |||
| } | |||
|
|
|||
| const clipboardy = require('clipboardy') | |||
There was a problem hiding this comment.
This should be lazy-required only when copy is needed
| @@ -149,10 +152,16 @@ module.exports = (api, options) => { | |||
| return | |||
| } | |||
|
|
|||
| let copied = '' | |||
| if (isFirstCompile && (args.copy || projectDevServerOptions.copy)) { | |||
There was a problem hiding this comment.
As @jkzing suggested I think we should keep it a command line flag only. --open is supported in devServer because webpack-dev-server also supports it.
|
@yyx990803 done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will copy the local url to the clipboard.
I use this feature of https://poi.js.org/ quite a lot.
It's not as aggressive as
--openbut just as convenient :)