Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Todos #1386

Merged
merged 8 commits into from
May 29, 2018
Merged

UI Todos #1386

merged 8 commits into from
May 29, 2018

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented May 29, 2018

Fix #1382

@Akryum Akryum self-assigned this May 29, 2018
@Akryum Akryum mentioned this pull request May 29, 2018
4 tasks
@Akryum Akryum requested a review from yyx990803 May 29, 2018 11:32
@@ -16,23 +16,31 @@
"test": "yarn run build && cd ../cli-ui-addon-webpack && yarn run build && cd ../cli-ui && yarn run test:run"
},
"dependencies": {
"@vue/cli": "^3.0.0-beta.12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this become a circular dependency?

@Akryum Akryum requested a review from yyx990803 May 29, 2018 13:05
@yyx990803 yyx990803 merged commit a3b2be8 into dev May 29, 2018
@Akryum Akryum deleted the fix-ui branch May 29, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants