Require.resolve fallback on node < 8.10.0 #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigomir
reviewed
May 30, 2018
| @@ -0,0 +1,5 @@ | |||
| exports.minNode = function (major, minor = 0, patch = 0) { | |||
| const parts = process.versions.node.split('.').map(v => parseInt(v)) | |||
| if (parts[0] >= major && parts[1] >= minor && parts[2] >= patch) return true | |||
There was a problem hiding this comment.
could return whole expression
| @@ -0,0 +1,5 @@ | |||
| exports.minNode = function (major, minor = 0, patch = 0) { | |||
| const parts = process.versions.node.split('.').map(v => parseInt(v)) | |||
There was a problem hiding this comment.
could use destructuring and give part names like const [major,minor,patch] = ...
i’m aware these are already taken, just suggesting.
packages/@vue/cli/lib/util/module.js
Outdated
| } | ||
| } | ||
|
|
||
| var filename = Module._findPath(request, paths, isMain) |
There was a problem hiding this comment.
Why is this var while others are const?
packages/@vue/cli/lib/util/module.js
Outdated
|
|
||
| var filename = Module._findPath(request, paths, isMain) | ||
| if (!filename) { | ||
| var err = new Error(`Cannot find module '${request}'`) |
|
@zigomir Thanks! ^.^ |
added 2 commits
May 30, 2018 15:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1396