Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config & task icons #1450

Merged
merged 5 commits into from
Jun 5, 2018
Merged

Refactor config & task icons #1450

merged 5 commits into from
Jun 5, 2018

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Jun 3, 2018

Breaking changes

  • file-icon for the configurations is removed
  • Configuration objects icon option changed and is now working differently: you can either use a material icon code or a custom image (see Public static files in the UI Plugin docs).
  • Task objects have a new icon option wich works exactly the same
  • By default, if no icon is provided for either the config or the task, the corresponding vue-cli plugin logo will be used instead (if any).

@Akryum Akryum requested a review from yyx990803 June 3, 2018 14:39
@Akryum Akryum self-assigned this Jun 3, 2018
@Akryum Akryum changed the title Ui remove file icon Refactor config & task icons Jun 3, 2018
@yyx990803
Copy link
Member

Make sure to record the breaking changes in the commit message per commit conventions when merging.

@Akryum Akryum merged commit 1c8f195 into dev Jun 5, 2018
@Akryum Akryum deleted the ui-remove-file-icon branch June 5, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants