Skip to content

Commit 958d55a

Browse files
committed
wip
1 parent 108c1c1 commit 958d55a

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

example/webpack.config.js

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ const VueLoaderPlugin = require('../dist/plugin')
44
module.exports = {
55
mode: 'development',
66
entry: path.resolve(__dirname, './main.js'),
7+
devtool: 'cheap-module-eval-source-map',
78
output: {
89
path: path.resolve(__dirname, 'dist'),
910
filename: 'bundle.js',

src/hotReload.ts

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
// __VUE_HMR_RUNTIME__ is injected to global scope by @vue/runtime-core
22

3-
export function genHotReloadCode(id: string, templateRequest?: string): string {
3+
export function genHotReloadCode(
4+
id: string,
5+
templateRequest: string | undefined
6+
): string {
47
return `
58
/* hot reload */
69
if (module.hot) {
710
const api = __VUE_HMR_RUNTIME__
811
module.hot.accept()
9-
if (!api.isRecorded('${id}')) {
10-
api.createRecord('${id}', script)
11-
} else {
12+
if (!api.createRecord('${id}', script)) {
1213
api.reload('${id}', script)
1314
}
1415
${templateRequest ? genTemplateHotReloadCode(id, templateRequest) : ''}

src/index.ts

+5-4
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ const loader: webpack.loader.Loader = function(source) {
115115
const scopedQuery = hasScoped ? `&scoped=true` : ``
116116
const attrsQuery = attrsToQuery(descriptor.template.attrs)
117117
const query = `?vue&type=template${idQuery}${scopedQuery}${attrsQuery}${inheritQuery}`
118-
const request = (templateRequest = stringifyRequest(src + query))
119-
templateImport = `import render from ${request}`
118+
templateRequest = stringifyRequest(src + query)
119+
templateImport = `import render from ${templateRequest}`
120120
}
121121

122122
// script
@@ -125,9 +125,10 @@ const loader: webpack.loader.Loader = function(source) {
125125
const src = descriptor.script.src || resourcePath
126126
const attrsQuery = attrsToQuery(descriptor.script.attrs, 'js')
127127
const query = `?vue&type=script${attrsQuery}${inheritQuery}`
128-
const request = stringifyRequest(src + query)
128+
const scriptRequest = stringifyRequest(src + query)
129129
scriptImport =
130-
`import script from ${request}\n` + `export * from ${request}` // support named exports
130+
`import script from ${scriptRequest}\n` +
131+
`export * from ${scriptRequest}` // support named exports
131132
}
132133

133134
// styles

0 commit comments

Comments
 (0)