Skip to content

Commit 99a5196

Browse files
committed
chore: add fixme comments to address issues with specific project names
1 parent e750609 commit 99a5196

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/pluginWebpack4.ts

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ class VueLoaderPlugin implements webpack.Plugin {
4646
const vueUse = vueRule.use as webpack.RuleSetLoader[]
4747
// get vue-loader options
4848
const vueLoaderUseIndex = vueUse.findIndex((u) => {
49+
// FIXME: this code logic is incorrect when project paths starts with `vue-loader-something`
4950
return /^vue-loader|(\/|\\|@)vue-loader/.test(u.loader || '')
5051
})
5152

src/pluginWebpack5.ts

+1
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ class VueLoaderPlugin implements Plugin {
134134

135135
// get vue-loader options
136136
const vueLoaderUseIndex = vueUse.findIndex((u) => {
137+
// FIXME: this code logic is incorrect when project paths starts with `vue-loader-something`
137138
return /^vue-loader|(\/|\\|@)vue-loader/.test(u.loader)
138139
})
139140

0 commit comments

Comments
 (0)