fix: filter out empty styles before generating code

jkzing · jkzing · commit c2e3e1986fff · 2019-01-06T18:34:48.000+08:00
diff --git a/lib/codegen/styleInjection.js b/lib/codegen/styleInjection.js
@@ -1,5 +1,6 @@
 const { attrsToQuery } = require('./utils')
 const hotReloadAPIPath = JSON.stringify(require.resolve('vue-hot-reload-api'))
+const allWhitespaceRE = /^\s+$/
 
 module.exports = function genStyleInjectionCode (
   loaderContext,
@@ -69,6 +70,8 @@ module.exports = function genStyleInjectionCode (
     }
   }
 
+  // filter out empty styles (with no `src` specified or only contains whitespaces)
+  styles = styles.filter(style => style.src || !allWhitespaceRE.test(style.content))
   // explicit injection is needed in SSR (for critical CSS collection)
   // or in Shadow Mode (for injection into shadow root)
   // In these modes, vue-style-loader exports objects with the __inject__

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`const { attrsToQuery } = require('./utils')`
`2`	`2`	`const hotReloadAPIPath = JSON.stringify(require.resolve('vue-hot-reload-api'))`
	`3`	`+const allWhitespaceRE = /^\s+$/`
`3`	`4`
`4`	`5`	`module.exports = function genStyleInjectionCode (`
`5`	`6`	`loaderContext,`
`@@ -69,6 +70,8 @@ module.exports = function genStyleInjectionCode (`
`69`	`70`	`}`
`70`	`71`	`}`
`71`	`72`
	`73`	+ // filter out empty styles (with no `src` specified or only contains whitespaces)
	`74`	`+ styles = styles.filter(style => style.src \|\| !allWhitespaceRE.test(style.content))`
`72`	`75`	`// explicit injection is needed in SSR (for critical CSS collection)`
`73`	`76`	`// or in Shadow Mode (for injection into shadow root)`
`74`	`77`	`// In these modes, vue-style-loader exports objects with the __inject__`