fix(VTooltip, VSnackbar): increasecontrast on dark theme #21184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Sek
added
a11y
J-Sek
force-pushed
the
fix/dark-tooltip-contrast
branch
from
4159814 to
27d81bf
Compare
J-Sek
force-pushed
the
fix/dark-tooltip-contrast
branch
from
27d81bf to
0c20616
Compare
johnleider
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can barely see the text. It is fine with light theme.
Current APCA score is 41.8 - not enough for any text
Dropped text color to pure black to make minimal adjustment to
surface-variant. Otherwise it would need to change to#e0e0e0and it would be more drastic change for other places (e.g. VSlider, VCarousel)Black on
#c8c8c8gets 74.3 which is still below the threshold, but good enough and I'd rather not reach some arbitrary number and have the text readable than wait forinverse-surfaceto be adopted.Before:
After: