Enabling a linter.

Author: mithro

.gitignore

@@ -8,3 +8,4 @@
 tools/*
 .testrepository
 *.png
+web-animations-4lint.js

.travis-run.sh

@@ -0,0 +1,25 @@
+#! /bin/bash
+
+set -x
+
+if [ x$MODE == x'check' ]; then
+  SUCCESS=0
+
+  # Check that the testcases json file has been updated
+  echo "Checking test cases is up to date..."
+  python ./test/update-testcases.py --dry-run
+  let "SUCCESS += $?"
+
+  # Check that the web-animations.js file passes lint checks
+  ./run-lint.sh
+  let "SUCCESS += $?"
+
+  exit $SUCCESS
+else
+  # For pull requests we don't have access to secure environment variables, so we just return true.
+  if [ x$BROWSER == "xRemote" -a x$SAUCE_ACCESS_KEY == x"" ]; then
+    exit 0
+  fi
+
+  echo ./run-tests.sh $ARGS | bash || exit 1
+fi

.travis-setup.sh

@@ -1,4 +1,4 @@
-#! /bin/sh
+#! /bin/bash
 
 set -x
 

.travis.yml

@@ -7,6 +7,7 @@ env:
     - SAUCE_USERNAME=mithro
 
   matrix:
+    - MODE='check'
     - BROWSER=Chrome-stable ARGS='-x -b Chrome -u'
     - BROWSER=Chrome-beta ARGS='-x -b Chrome -u'
     - BROWSER=Chrome-unstable ARGS='-x -b Chrome -u'
@@ -29,13 +30,7 @@ install:
   - ./.travis-setup.sh
 
 script:
-  - python ./test/update-testcases.py --dry-run || (echo "Please run update-testcases!"; false)
-  # For pull requests we don't have access to secure environment variables, so we just return true.
-  - if [ x$BROWSER == "xRemote" -a x$SAUCE_ACCESS_KEY == "x" ]; then
-      true;
-    else
-      echo ./run-tests.sh $ARGS | bash;
-    fi
+  - ./.travis-run.sh
 
 after_failure:
   - for file in *.log; do echo $file; echo "======================"; cat $file; done || true

run-lint.sh

@@ -0,0 +1,19 @@
+#! /bin/bash
+
+# Update git submodules
+git submodule init
+git submodule update
+
+# If already in a VIRTUAL_ENV assume the person knows what they are doing,
+# otherwise set up a python virtualenv with all the needed requirements.
+if [ x$VIRTUAL_ENV == x"" ]; then
+  cd tools/python
+  source setup.sh
+  cd ../..
+fi
+
+# Comment out the (function() {} ) wrapper
+sed -e'17s-^-//-' -e'$s-^-//-' web-animations.js > web-animations-4lint.js
+
+gjslint --summary --nojsdoc --strict web-animations-4lint.js
+exit $?

run-tests.sh

@@ -12,4 +12,4 @@ if [ x$VIRTUAL_ENV == x"" ]; then
   cd ../..
 fi
 
-exec python tools/python/run-tests.py $@
+exec python tools/python/run-tests.py "$@"

tools/python/requirements.txt

@@ -2,6 +2,8 @@ testtools>=0.9.30
 python-subunit # subunit
 selenium
 
+-e svn+http://closure-linter.googlecode.com/svn/trunk/#egg=closer-linter
+
 # Requirements for using -x
 pyvirtualdisplay
 pyscreenshot