Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stroke dash array/offset do not animate properly in Safari #98

Open
alexjlockwood opened this issue Dec 1, 2016 · 8 comments · May be fixed by #131
Open

Stroke dash array/offset do not animate properly in Safari #98

alexjlockwood opened this issue Dec 1, 2016 · 8 comments · May be fixed by #131

Comments

@alexjlockwood
Copy link

alexjlockwood commented Dec 1, 2016

Compare the behavior of the following JS fiddle animation in Chrome vs. Safari (click on the icons to begin the animation): https://jsfiddle.net/alexjlockwood/79zh7228/6/

Using web-animations-js v2.2.2.

There are a number of other examples that show the same behavior here as well: http://www.androiddesignpatterns.com/2016/11/introduction-to-icon-animation-techniques.html

@alexjlockwood
Copy link
Author

Here is a video of the non-buggy behavior I see in Chrome: https://youtu.be/u2iViqqx1OI

And here is a video of the buggy behavior I see in Safari: https://youtu.be/v_Tx2peDnB8

@alancutter
Copy link
Contributor

Looks like Chrome works fine because it's using native, when forcing the polyfill (by using the dev.js version) the buggy behaviour is seen in Chrome.
https://jsfiddle.net/86126am2/

@alancutter
Copy link
Contributor

alancutter commented Feb 8, 2017

Seems the polyfill just doesn't have a handler for strokeDasharray: https://github.com/web-animations/web-animations-js/search?utf8=%E2%9C%93&q=strokeDasharray&type=Code

@alexjlockwood
Copy link
Author

Any updates on this?

@alexjlockwood
Copy link
Author

alexjlockwood commented Apr 22, 2017

This bug does not seem like it has been fixed to me. Can you confirm that the updated jsfiddle animation works as expected in Safari? I updated the dependency to v2.2.5 and I'm still seeing the same behavior.

https://jsfiddle.net/alexjlockwood/79zh7228/

@alexjlockwood
Copy link
Author

I also still see the same behavior in Chrome when I use the dev.js version: https://rawgit.com/web-animations/web-animations-js/dev/web-animations.dev.js

@alancutter
Copy link
Contributor

Looks like support for unitless values is missing. Confirmed that adding 'px' to the example makes it work in the polyfill: https://jsfiddle.net/79zh7228/8/

@alancutter alancutter linked a pull request Apr 26, 2017 that will close this issue
@scttcper
Copy link

Can confirm adding units fixed the issue for me. https://scttcper.github.io/ngx-trend/ line should animate on page load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants