IDB: Make Transaction::abort() throw error when txn is committing

Ensure the abort() method throws an “InvalidStateError” DOMException
when called during the committing state of a transaction. Update the
transaction state to kCommitting during auto-commits to align with
the spec (IndexedDB Spec).

Bug: 390986925
Change-Id: Id7c1bc8d56cacc761b00c6ea41c24a518f5c0693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6176649
Auto-Submit: Garima Chadha <[email protected]>
Commit-Queue: Garima Chadha <[email protected]>
Reviewed-by: Abhishek Shanthkumar <[email protected]>
Reviewed-by: Steve Becker <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1417978}

Author: Garima Chadha

IndexedDB/idbtransaction_abort.any.js

@@ -2,6 +2,8 @@
 // META: global=window,worker
 // META: script=resources/support.js
 
+// Spec: https://w3c.github.io/IndexedDB/#transaction-abort
+
 'use strict';
 
 async_test(t => {
@@ -14,7 +16,6 @@ async_test(t => {
     db = e.target.result;
     let txn = e.target.transaction;
     let objStore = db.createObjectStore('store');
-
     objStore.add(record, 1);
     objStore.add(record, 2);
     let index =
@@ -34,4 +35,73 @@ async_test(t => {
 
     e.target.transaction.oncomplete = fail(t, 'got complete, expected abort');
   };
-});
+}, 'Abort event should fire during transaction');
+
+indexeddb_test(
+    (t, db) => {
+      db.createObjectStore('blobs', {keyPath: 'id', autoIncrement: true});
+    },
+    (t, db) => {
+      const txn = db.transaction('blobs', 'readwrite');
+      const objectStore = txn.objectStore('blobs');
+      const data = new Blob(['test'], {type: 'text/plain'});
+
+      const putRequest = objectStore.put({id: 0, data: data});
+
+      putRequest.onsuccess = t.step_func(() => {
+        t.step_timeout(() => {
+          assert_throws_dom('InvalidStateError', () => {
+            txn.abort();
+          }, 'Abort should throw InvalidStateError on an auto-committing transaction.');
+        }, 0);
+      });
+
+      // Ensure the transaction completes.
+      txn.oncomplete = t.step_func(() => {
+        t.done();
+      });
+
+      // Abort should fail once the transaction has started committing.
+      txn.onabort = t.step_func((event) => {
+        assert_unreached('Unexpected transaction abort: ' + event.target.error);
+      });
+      t.add_cleanup(() => {
+        if (db) {
+          db.close();
+        }
+      });
+    },
+    `Abort during auto-committing should throw InvalidStateError.`);
+
+indexeddb_test(
+    (t, db) => {
+      db.createObjectStore('blobs', {keyPath: 'id', autoIncrement: true});
+    },
+    (t, db) => {
+      const txn = db.transaction('blobs', 'readwrite');
+      const objectStore = txn.objectStore('blobs');
+      const data = new Blob(['test'], {type: 'text/plain'});
+
+      // Put the object into the store.
+      const putRequest = objectStore.put({id: 0, data: data});
+
+      // Handle transaction completion.
+      txn.oncomplete = t.step_func(() => {
+        assert_throws_dom('InvalidStateError', () => {
+          txn.abort();
+        }, 'Abort should throw InvalidStateError on a completed transaction.');
+        t.done();
+      });
+
+      // Handle transaction error.
+      txn.onerror = t.step_func((event) => {
+        assert_unreached('Unexpected transaction error: ' + event.target.error);
+      });
+
+      t.add_cleanup(() => {
+        if (db) {
+          db.close();
+        }
+      });
+    },
+    `Abort on completed transaction should throw InvalidStateError.`);