review

Author: annevk

Diff for: html/browsers/history/the-location-interface/location-protocol-setter-sameish.html

@@ -20,7 +20,7 @@
         assert_equals(self[index].location.protocol, "http:");
       });
       self[index].location.protocol = val;
-    }, `Set location.protocol to ${encodeURI(val)} (percent-encoded)`);
+    }, `Set location.protocol to ${encodeURI(val)} (percent-encoded here for clarity)`);
   });
 }
 </script>

Diff for: html/browsers/history/the-location-interface/location-protocol-setter.html

@@ -37,6 +37,8 @@
     '\x01',
     '\x09', // becomes the empty string
     '\x0A', // becomes the empty string
+    '\x0C',
+    '\x0D',
     '\x20',
     '\x21',
     '\x7F',
@@ -83,7 +85,7 @@
   broken.forEach(val => {
     test(() => {
       assert_throws_dom("SyntaxError", () => { location.protocol = val })
-    }, encodeURI(val) + " (percent-encoded) is not a scheme")
+    }, `${encodeURI(val)} (percent-encoded here for clarity) is not a scheme`)
   })
   let c = 0
   async_test((t) => {

Diff for: url/resources/setters_tests.json

@@ -279,6 +279,39 @@
               "protocol": "https:",
               "port": ""
             }
+        },
+        {
+            "comment": "Non-tab/newline C0 controls result in no-op",
+            "href": "http://test/",
+            "new_value": "https\u0000",
+            "expected": {
+              "href": "http://test/",
+              "protocol": "http:"
+            }
+        },
+        {
+            "href": "http://test/",
+            "new_value": "https\u000C",
+            "expected": {
+              "href": "http://test/",
+              "protocol": "http:"
+            }
+        },
+        {
+            "href": "http://test/",
+            "new_value": "https\u000D",
+            "expected": {
+              "href": "http://test/",
+              "protocol": "http:"
+            }
+        },
+        {
+            "href": "http://test/",
+            "new_value": "https\u0020",
+            "expected": {
+              "href": "http://test/",
+              "protocol": "http:"
+            }
         }
     ],
     "username": [