docs: Fix example of tx usage (#5402)

acolytec3 · nikoulai · avkos · web-flow · commit f616e9f75b37 · 2022-09-07T17:07:41.000+02:00
* docs: Fix example of tx usage

* chore: update changelog

* Fix changelog

* Add example entry back

Co-authored-by: Nikos Iliakis &lt;nikoulai@users.noreply.github.com&gt;
Co-authored-by: Oleksii Kosynskyi &lt;oleksii.kosynskyi@gmail.com&gt;
Co-authored-by: Junaid &lt;86780488+jdevcs@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -590,6 +590,8 @@ Released with 1.0.0-beta.37 code base.
 ### Changed
 -  Updated `sha3` and `sha3Raw` type definition to accept `Buffer`
 -  Removing legacy field in lerna.json (#5403)
+-  Correct `eth_sendSignedTransaction` code example (#5402)
+
 
 ### Fixed
 -  Browser builds support polyfills (#5031) (#5053) (#4659) (#4767)
diff --git a/docs/web3-eth.rst b/docs/web3-eth.rst
@@ -1666,9 +1666,9 @@ Example
     }
 
     var tx = new Tx(rawTx, {'chain':'ropsten'});
-    tx.sign(privateKey);
+    var signedTx = tx.sign(privateKey);
 
-    var serializedTx = tx.serialize();
+    var serializedTx = signedTx.serialize();
 
     // console.log(serializedTx.toString('hex'));
     // 0xf889808609184e72a00082271094000000000000000000000000000000000000000080a47f74657374320000000000000000000000000000000000000000000000000000006000571ca08a8bbf888cfa37bbf0bb965423625641fc956967b81d12e23709cead01446075a01ce999b56a8a88504be365442ea61239198e23d1fce7d00fcfc5cd3b44b7215f

Original file line number	Diff line number	Diff line change
`@@ -1666,9 +1666,9 @@ Example`
`1666`	`1666`	`}`
`1667`	`1667`
`1668`	`1668`	`var tx = new Tx(rawTx, {'chain':'ropsten'});`
`1669`		`- tx.sign(privateKey);`
	`1669`	`+ var signedTx = tx.sign(privateKey);`
`1670`	`1670`
`1671`		`- var serializedTx = tx.serialize();`
	`1671`	`+ var serializedTx = signedTx.serialize();`
`1672`	`1672`
`1673`	`1673`	`// console.log(serializedTx.toString('hex'));`
`1674`	`1674`	`// 0xf889808609184e72a00082271094000000000000000000000000000000000000000080a47f74657374320000000000000000000000000000000000000000000000000000006000571ca08a8bbf888cfa37bbf0bb965423625641fc956967b81d12e23709cead01446075a01ce999b56a8a88504be365442ea61239198e23d1fce7d00fcfc5cd3b44b7215f`