Use pify or so

[levino]

For example here:

https://github.com/ethereum/web3.js/blob/2cfa2ea184466d52bca62f52c82aa570fd0ad9a9/packages/web3-eth-accounts/src/Accounts.js#L219-L220

There is a lot of boilerplate in every method to handle callbacks and promises at the same time. That is not necessary. You can just write the whole library in one style and then finally wrap everything with pify or something you write yourself. The current "solution" is very dangerous because someone might some day forget to also return the promise.

Also when a callback is provided, I find that no promise schould be returned. Atm you call the callback and return the promise which super funky.

[levino]

https://github.com/sindresorhus/pify

[levino]

It would go like this:

import callbackify from 'callbackify'

const _someMethod(data) {//returns a Promise
   ...
}

const someMethod(data, callback) {
   if (callback) {
     return callbackify(_someMethod)(data, callback)
   }
   return _someMethod(data)
}

[nivida]

I think this issue can be closed and referenced in the #2224 issue.

[levino]

I disagree. I think #2224 will not be implemented soon and introduce breaking changes. This issue right here is simply about improvement of code quality.

[levino]

I changed a bit the code above and used callbackify because this will allow to write all code in Promise style and then only convert it to support callbacks too.