Skip to content
This repository was archived by the owner on Sep 28, 2020. It is now read-only.

Commit 8cb02a6

Browse files
ricardogobbosouzaevilebottnawi
authored andcommitted
docs: update gotchas (#284)
1 parent 2a72daa commit 8cb02a6

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

README.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,11 @@ module.exports = {
298298

299299
## Gotchas
300300

301-
### NoErrorsPlugin
301+
### NoEmitOnErrorsPlugin for `webpack >= 4`
302+
303+
`NoEmitOnErrorsPlugin` is now automatically enabled in webpack 4, when mode is either unset, or set to production. So even ESLint warnings will fail the build. No matter what error settings are used for `eslint-loader`, except if `emitWarning` enabled.
304+
305+
### NoErrorsPlugin for `webpack < 4`
302306

303307
`NoErrorsPlugin` prevents webpack from outputting anything into a bundle. So even ESLint warnings
304308
will fail the build. No matter what error settings are used for `eslint-loader`.
@@ -316,7 +320,9 @@ See [#129](https://github.com/webpack-contrib/eslint-loader/issues/129).
316320
---
317321

318322
## Changelog
323+
319324
[Changelog](CHANGELOG.md)
320325

321326
## License
327+
322328
[MIT](./LICENSE)

0 commit comments

Comments
 (0)