Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Needs better documentation #30

Closed
zenflow opened this issue Jun 30, 2015 · 2 comments
Closed

Needs better documentation #30

zenflow opened this issue Jun 30, 2015 · 2 comments

Comments

@zenflow
Copy link
Contributor

zenflow commented Jun 30, 2015

@webpack

This repo would ideally give a bit more details in the readme, for easy reference.

  • which modules are implemented (for example, 'process') and which are not (for example, 'fs')
  • how the implemented modules differ from their node counterparts

I would gladly volunteer to take this task if it pleases you.

I'll note that it's of particular importance to me that the browser member of process (i.e. process.browser) gets documented. It would be a brief mention, and I would by no means go into details or examples of how to use it, but I will breifly argue it's significance to you here...

You can reference process.browser in isomorphic code that

  • adjusts it's behavior depending on which environment it's in
  • is fully portable within the nodejs/iojs/browserify/webpack ecosystem, and
  • is concise and Don't Repeat Yourself (DRY)

That said, I intend on doing a thorough documentation of each module, not just process, should you welcome my offer to help.

So, I guess my question is: Would you like to see a PR with enhanced documentation as described?

@zenflow
Copy link
Contributor Author

zenflow commented Jul 4, 2015

@sokra I'll take no response as a thumbs-up to do this and submit a PR :)

@sokra
Copy link
Member

sokra commented Jul 5, 2015

👍

This package only references the individual npm packages for the browser variants. For detailed documentation you should be able the link to the readmes.

@zenflow zenflow mentioned this issue Jul 8, 2015
@zenflow zenflow closed this as completed Oct 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants