Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Any chance of updating latest pre-1.0 version to use newer version of buffer? #39

Closed
bergr01 opened this issue May 11, 2016 · 5 comments

Comments

@bergr01
Copy link

bergr01 commented May 11, 2016

Hi
I'm currently using latest stable version of webpack (1.13.0) that relies on "node-libs-browser": ">= 0.4.0 <=0.6.0" which in turn uses "buffer": "^3.0.3". Any chance of bumping that up to utilize buffer 4.3.0 that's used by node-libs-browser v1.0? I'm running into an issue that was resolved in buffer since 3.0.3 and would prefer not to edit the buffer source under node_modules manually on x of the build machines.

@feross
Copy link

feross commented May 17, 2016

Edit: Oh, misunderstood this issue. The latest buffer is already in package.json. You're asking them to bump an old version. That's a difficult ask.


I posted a similar issue about the need to update stream-http. #38

I don't even use webpack, so I could care less. But I help maintain buffer and webtorrent and both have seen opened issues by webpack users complaining about already fixed bugs because webpack is using old versions of buffer and stream-http.

@orlandodemauro
Copy link

@bergr01 issue fixed in #42. new node-libs-browser package published (v0.6.0) with buffer v^4.9.0 dependency. it will be automatically picked by webpack 1.13.0. This issue can be closed

@Offirmo
Copy link

Offirmo commented Aug 18, 2016

@orlandodemauro I have an install issue since your update #43

@jhnns
Copy link
Member

jhnns commented Nov 23, 2016

We will bump node-libs-browser to ^1.1.0 in webpack-1, see webpack/webpack#3355

@jhnns jhnns closed this as completed Nov 23, 2016
@jhnns
Copy link
Member

jhnns commented Nov 24, 2016

There was a hidden breaking change with crypto-browserify so that we couldn't upgrade it to the most recent version. However, this PR introduces the most recent versions without breaking change to webpack-1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants