-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT]: Yarn PnP support for serve command #1080
Comments
Yep we can do that, will need for #1011 to land then we can fix this. |
@Loonride could you pick this up? Would greatly appreciate it and we really need it. |
@evenstensberg I already added webpack-cli/packages/serve/package.json Lines 26 to 33 in 181822f
Do we need this for all the packages (serve, init, etc.)? |
|
For |
@evenstensberg should you install Oh my god, seriously? Where is 0CJS? Basic commands like:
should works out of box without any additional installation. |
Look at the others CLI programs, no one forces you to install additional modules for basic work |
Is your feature request related to a problem? Please describe.
When using yarn v2, we can't use
serve
as@webpack-cli/serve
is not declared as a dependency. It should be be declared as an optional peer dependency. Same forwebpack-dev-server
:Additional context
Similar work for
webpack-dev-server
: webpack/webpack-dev-server#2191 (but not enough as next major version will not include the webpack-dev-server binary, and we will have to use webpack-cli)Optional peer dependencies RFC: https://github.com/yarnpkg/rfcs/blob/master/accepted/0000-optional-peer-dependencies.md
The text was updated successfully, but these errors were encountered: