Skip to content

Commit a21d4f7

Browse files
committed
tools: fix incorrect version history order
This fixes an error in parseYAML(text), the version sorting coudn't be right as we compared an arrify string (ie. a = ["v18.11, v16.7.0"]) with an array of strings (ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b). minVersion(a) couldn't find the minimum version with an arrify string like a = ["v18.11, v16.7.0"]. That's why incorrect version history orders sometimes appeared. Fixes: nodejs#45670
1 parent f6052c6 commit a21d4f7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tools/doc/html.mjs

+3-3
Original file line numberDiff line numberDiff line change
@@ -325,18 +325,18 @@ function parseYAML(text) {
325325
const removed = { description: '' };
326326

327327
if (meta.added) {
328-
added.version = meta.added.join(', ');
328+
added.version = meta.added;
329329
added.description = `<span>Added in: ${added.version}</span>`;
330330
}
331331

332332
if (meta.deprecated) {
333-
deprecated.version = meta.deprecated.join(', ');
333+
deprecated.version = meta.deprecated;
334334
deprecated.description =
335335
`<span>Deprecated since: ${deprecated.version}</span>`;
336336
}
337337

338338
if (meta.removed) {
339-
removed.version = meta.removed.join(', ');
339+
removed.version = meta.removed;
340340
removed.description = `<span>Removed in: ${removed.version}</span>`;
341341
}
342342

0 commit comments

Comments
 (0)