chore: pin node/npm version for build workflow (#1496)

Ok so during npm install symlinks were not being created where required. I believe this is some sort of regression with a new minor/patch version of node or npm. Using volta we already pin the node version locally, so it makes sense to do it in the workflow as well.

Removed any explicit node versioning where it is unnecessary.

Also combined all of the build into 1 command, because it shows the power of nx.

Fixes #1479 🤞 

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.

Author: MarkMcCulloh

.github/workflows/build.yml

@@ -15,7 +15,6 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  NODEJS_VERSION: "18.x"
   # Testing runs out of memory without this
   NODE_OPTIONS: "--max-old-space-size=4096"
   PROJEN_BUMP_VERSION: "0.0.0-dev.${{ github.run_id }}.${{ github.run_attempt }}"
@@ -100,10 +99,9 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v3
 
-      - name: Setup Node
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ env.NODEJS_VERSION }}
+      # Reads versions from root package.json "volta" section
+      - name: Setup Node/NPM with pinned Volta version
+        uses: volta-cli/[email protected]
 
       - name: Install Rust
         uses: actions-rs/toolchain@v1
@@ -121,21 +119,14 @@ jobs:
       - name: Lint Nx
         run: npx nx workspace-lint
 
-      - name: Build and Unit Test
+      - name: Build, Test, and Package
         uses: MansaGroup/nrwl-nx-action@v2
         with:
-          targets: "build"
+          targets: "build,test,package"
           all: true
           # Exclude E2E testing
           args: "--exclude=hangar --configuration=release --output-style=stream --verbose"
 
-      - name: Create NPM packages
-        uses: MansaGroup/nrwl-nx-action@v2
-        with:
-          targets: "package"
-          projects: "winglang,sdk"
-          args: "--configuration=release --output-style=stream --verbose"
-
       - name: Upload Wing CLI
         uses: actions/upload-artifact@v2
         with:
@@ -230,11 +221,6 @@ jobs:
       - name: Download Build Artifacts
         uses: actions/download-artifact@v2
 
-      - name: Setup Node
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ env.NODEJS_VERSION }}
-
       - name: Tag commit
         uses: tvdias/[email protected]
         if: ${{ needs.prepare.outputs.last-version != needs.prepare.outputs.version }}

apps/jsii-docgen/project.json

@@ -6,7 +6,7 @@
       "executor": "nx:run-script",
       "options": {
         "cwd": "apps/jsii-docgen",
-        "script": "build"
+        "script": "compile"
       }
     }
   }

apps/wing-api-checker/project.json

@@ -6,7 +6,7 @@
       "executor": "nx:run-script",
       "options": {
         "cwd": "apps/wing-api-checker",
-        "script": "build"
+        "script": "compile"
       }
     }
   }

apps/wing-playground/package-lock.json

@@ -16,15 +16,15 @@
     "contributors:check": "all-contributors check",
     "contributors:generate": "all-contributors generate",
     "docs": "./scripts/docsite.sh",
-    "install:hangar": "npm --prefix tools/hangar install",
-    "install:jsii-docgen": "npm --prefix apps/jsii-docgen install",
-    "install:sdk": "npm --prefix libs/wingsdk install",
-    "install:tree-sitter-wing": "npm --prefix libs/tree-sitter-wing install",
-    "install:vscode-wing": "npm --prefix apps/vscode-wing install",
+    "install:hangar": "npm --prefix tools/hangar --install-links=false install",
+    "install:jsii-docgen": "npm --prefix apps/jsii-docgen --install-links=false install",
+    "install:sdk": "npm --prefix libs/wingsdk --install-links=false install",
+    "install:tree-sitter-wing": "npm --prefix libs/tree-sitter-wing --install-links=false install",
+    "install:vscode-wing": "npm --prefix apps/vscode-wing --install-links=false install",
     "install:wasi": "bash scripts/setup_wasi.sh",
-    "install:wing-api-checker": "npm --prefix apps/wing-api-checker install",
-    "install:wing-playground": "npm --prefix apps/wing-playground install",
-    "install:winglang": "npm --prefix apps/wing install",
+    "install:wing-api-checker": "npm --prefix apps/wing-api-checker --install-links=false install",
+    "install:wing-playground": "npm --prefix apps/wing-playground --install-links=false install",
+    "install:winglang": "npm --prefix apps/wing --install-links=false install",
     "nx": "nx",
     "postinstall": "run-p -l --max-parallel 3 'install:*'",
     "test": "nx run-many --target=test --all=true"