Skip to content

Commit 227ca0a

Browse files
authored
Add space between info.message and meta.message (#1740)
* Update logger.js * fix tests
1 parent ef97171 commit 227ca0a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/winston/logger.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ class Logger extends Transform {
238238
message: msg
239239
});
240240

241-
if (meta.message) info.message += `${meta.message}`;
241+
if (meta.message) info.message = `${info.message} ${meta.message}`;
242242
if (meta.stack) info.stack = meta.stack;
243243

244244
this.write(info);

test/formats/errors.test.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ describe('format.errors (integration)', function () {
110110
format.printf(info => info.message)
111111
));
112112

113-
logger.log('info', 'Caught error: ', new Error('Errors lack .toJSON() lulz'));
113+
logger.log('info', 'Caught error:', new Error('Errors lack .toJSON() lulz'));
114114
});
115115

116116
it('logger.log(level, msg, meta<error>) [custom error properties]', (done) => {
@@ -132,7 +132,7 @@ describe('format.errors (integration)', function () {
132132
format.printf(info => info.message)
133133
));
134134

135-
logger.log('info', 'Caught error: ', err);
135+
logger.log('info', 'Caught error:', err);
136136
});
137137

138138
it('logger.<level>(error)', (done) => {
@@ -209,7 +209,7 @@ describe('format.errors (integration)', function () {
209209
format.printf(info => info.message)
210210
));
211211

212-
logger.info('Caught error: ', new Error('Errors lack .toJSON() lulz'));
212+
logger.info('Caught error:', new Error('Errors lack .toJSON() lulz'));
213213
});
214214

215215
it('logger.<level>(msg, meta<error>) [custom error properties]', (done) => {
@@ -231,7 +231,7 @@ describe('format.errors (integration)', function () {
231231
format.printf(info => info.message)
232232
));
233233

234-
logger.info('Caught error: ', err);
234+
logger.info('Caught error:', err);
235235
});
236236

237237
it(`Promise.reject().catch(logger.<level>)`, (done) => {

0 commit comments

Comments
 (0)