Moves viewControllerForKey to use viewForKey with transitions where (#6238)

Moves viewControllerForKey to use viewForKey with transitions where appropriate as discussed in this Stack Overflow post: https://stackoverflow.com/questions/24338700/from-view-controller-disappears-using-uiviewcontrollercontexttransitioning/25193675#25193675

This mainly resolves an issue when using animations with `dismissModal` that results in all views being removed and a black screen appearing as discussed in #6195 

The remaining `viewControllerForKey` calls should probably be removed too where their `view` property is being used, but this seems to resolve the bug for now at least!

Author: simonmitchell

lib/ios/ModalDismissTransitionDelegate.m

@@ -13,12 +13,12 @@ - (NSArray *)createTransitionsFromVC:(UIViewController *)fromVC toVC:(UIViewCont
 }
 
 - (void)prepareTransitionContext:(id<UIViewControllerContextTransitioning>)transitionContext {
-    UIViewController* toVC = [transitionContext viewControllerForKey:UITransitionContextToViewControllerKey];
-    UIViewController* fromVC = [transitionContext viewControllerForKey:UITransitionContextFromViewControllerKey];
+    UIView* toView = [transitionContext viewForKey:UITransitionContextToViewKey];
+    UIView* fromView = [transitionContext viewForKey:UITransitionContextFromViewKey];
 
-    fromVC.view.alpha = 0;
-    [transitionContext.containerView addSubview:toVC.view];
-    [transitionContext.containerView addSubview:fromVC.view];
+    fromView.alpha = 0;
+    [transitionContext.containerView addSubview:toView];
+    [transitionContext.containerView addSubview:fromView];
 }
 
 @end

lib/ios/ModalTransitionDelegate.m

@@ -15,9 +15,9 @@ - (NSArray *)createTransitionsFromVC:(UIViewController *)fromVC toVC:(UIViewCont
 }
 
 - (void)prepareTransitionContext:(id<UIViewControllerContextTransitioning>)transitionContext {
-    UIViewController* toVC = [transitionContext viewControllerForKey:UITransitionContextToViewControllerKey];
-    toVC.view.alpha = 0;
-    [transitionContext.containerView addSubview:toVC.view];
+    UIView* toView = [transitionContext viewForKey:UITransitionContextToViewKey];
+    toView.alpha = 0;
+    [transitionContext.containerView addSubview:toView];
 }
 
 - (nullable id <UIViewControllerAnimatedTransitioning>)animationControllerForPresentedController:(UIViewController *)presented presentingController:(UIViewController *)presenting sourceController:(UIViewController *)source {

lib/ios/RNNAnimationsTransitionDelegate.m

@@ -22,21 +22,21 @@ - (NSTimeInterval)transitionDuration:(id <UIViewControllerContextTransitioning>)
 }
 
 - (void)animateTransition:(id<UIViewControllerContextTransitioning>)transitionContext {
-	UIViewController* toViewController = [transitionContext viewControllerForKey:UITransitionContextToViewControllerKey];
-	UIViewController* fromViewController = [transitionContext viewControllerForKey:UITransitionContextFromViewControllerKey];
+	UIView* toView = [transitionContext viewForKey:UITransitionContextToViewKey];
+	UIView* fromView = [transitionContext viewForKey:UITransitionContextFromViewKey];
 
 	[CATransaction begin];
 	[CATransaction setCompletionBlock:^{
 		[transitionContext completeTransition:![transitionContext transitionWasCancelled]];
 	}];
 
 	if (_isDismiss) {
-		[[transitionContext containerView] addSubview:toViewController.view];
-		[[transitionContext containerView] addSubview:fromViewController.view];
-		[self animateElement:self.transitionOptions view:fromViewController.view elementName:@"content"];
+		[[transitionContext containerView] addSubview:toView];
+		[[transitionContext containerView] addSubview:fromView];
+		[self animateElement:self.transitionOptions view:fromView elementName:@"content"];
 	} else {
-		[[transitionContext containerView] addSubview:toViewController.view];
-		[self animateElement:self.transitionOptions view:toViewController.view elementName:@"content"];
+		[[transitionContext containerView] addSubview:toView];
+		[self animateElement:self.transitionOptions view:toView elementName:@"content"];
 	}
 
 	[CATransaction commit];

lib/ios/RNNPushAnimation.m

@@ -13,11 +13,12 @@ - (NSTimeInterval)transitionDuration:(id <UIViewControllerContextTransitioning>)
 }
 
 - (void)animateTransition:(id<UIViewControllerContextTransitioning>)transitionContext {
-	UIViewController* fromViewController = [transitionContext viewControllerForKey:UITransitionContextFromViewControllerKey];
-	UIViewController* toViewController = [transitionContext viewControllerForKey:UITransitionContextToViewControllerKey];
+    UIViewController *toViewController = [transitionContext viewControllerForKey:UITransitionContextToViewControllerKey];
+	UIView* fromView = [transitionContext viewForKey:UITransitionContextFromViewKey];
+	UIView* toView = [transitionContext viewForKey:UITransitionContextToViewKey];
 
-	[[transitionContext containerView] addSubview:fromViewController.view];
-	[[transitionContext containerView] addSubview:toViewController.view];
+	[[transitionContext containerView] addSubview:fromView];
+	[[transitionContext containerView] addSubview:toView];
 
 	[CATransaction begin];
 	[CATransaction setCompletionBlock:^{

lib/ios/TransitionDelegate.m

@@ -26,9 +26,9 @@ - (void)animateTransition:(id<UIViewControllerContextTransitioning>)transitionCo
 }
 
 - (void)prepareTransitionContext:(id<UIViewControllerContextTransitioning>)transitionContext {
-    UIViewController* toVC = [transitionContext viewControllerForKey:UITransitionContextToViewControllerKey];
-    toVC.view.alpha = 0;
-    [transitionContext.containerView addSubview:toVC.view];
+    UIView* toView = [transitionContext viewForKey:UITransitionContextToViewKey];
+    toView.alpha = 0;
+    [transitionContext.containerView addSubview:toView];
 }
 
 - (void)performAnimationOnce {