Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new multi remote attachment content type #243

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

cameronvoell
Copy link
Contributor

See https://github.com/xmtp/XIPs/blob/main/XIPs/xip-50-multiple-remote-attachments-content-type.md

This XIP proposes a new MultiRemoteAttachment content type inspired by the existing RemoteAttachment content type, that instead allows for multiple remote attachments to be sent in a single message.
Where the RemoteAttachment content is a URL pointing to an encrypted protobuf EncodedContent, the MultiRemoteAttachment content is a protobuf struct containing an array of remote attachment structs, each specifying a URL, as well as a contentDigest, contentLength, nonce, scheme, and filename.
The idea being that the multiple remote attachment encoded content parameters will specify a secret key and salt for encrypting/decrypting all attachments, but each attachment will have its own nonce, and contentDigest for validating the integrity of the individual attachments.

@cameronvoell cameronvoell requested a review from a team as a code owner February 4, 2025 17:26
@cameronvoell cameronvoell marked this pull request as draft February 4, 2025 17:26
@cameronvoell cameronvoell force-pushed the cv/multi-attachment-content-type branch from 20dc838 to bb6f03e Compare February 4, 2025 17:36
@cameronvoell cameronvoell force-pushed the cv/multi-attachment-content-type branch from 66ffa5b to 11d13ae Compare February 7, 2025 11:45
@cameronvoell cameronvoell force-pushed the cv/multi-attachment-content-type branch from 22d5d97 to 2c53291 Compare February 12, 2025 00:43
@cameronvoell cameronvoell marked this pull request as ready for review February 13, 2025 14:46
@cameronvoell cameronvoell merged commit 0bd0ae6 into main Feb 13, 2025
4 checks passed
@cameronvoell cameronvoell deleted the cv/multi-attachment-content-type branch February 13, 2025 15:00
Copy link

🎉 This PR is included in version 3.74.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants