Skip to content

Commit a5076d9

Browse files
RaisinTenxtx1130
authored andcommitted
build: improve the format-cpp error message
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#42765 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent d3c9ad6 commit a5076d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/linters.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
echo
7979
echo 'ERROR: Please run:'
8080
echo
81-
echo ' CLANG_FORMAT_START="$(git merge-base HEAD <target-branch-name>)" make format-cpp'
81+
echo " CLANG_FORMAT_START="$\(git merge-base HEAD ${GITHUB_BASE_REF}\)" make format-cpp"
8282
echo
8383
echo 'to format the commits in your branch.'
8484
exit "$EXIT_CODE"

0 commit comments

Comments
 (0)