Skip to content

Collaboration with OpenTelemetry #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixge opened this issue Jan 31, 2025 · 5 comments
Open

Collaboration with OpenTelemetry #13

felixge opened this issue Jan 31, 2025 · 5 comments

Comments

@felixge
Copy link

felixge commented Jan 31, 2025

Hello,

my name is Felix and I'm writing you in my capacity as a maintainer in the OpenTelemetry Profiling SIG.

I read your announcement post of perforator with great interest. It's a really fantastic article covering a lot of ground and novel ideas (e.g. minicores).

Towards the end of your article you mention:

We plan to contribute our experience to developing a universal profile format within OpenTelemetry.

I'd like to invite you to join one of our upcoming SIG meetings and/or our online discussion channels: https://github.com/open-telemetry/community#sig-profiles

As you're probably aware, the profiling SIG is also working on an ebpf profiler, so perhaps there are opportunities for collaborating on the core profiling technologies in addition to the profiling format ideas you mentioned.

Meanwhile: Thank you for open sourcing perforator and advancing the state of art in profiling! ❤

@BigRedEye
Copy link
Contributor

Thank you very much for your kind words and invitation to collaborate!

We have been following the excellent work on the eBPF profiler with great interest. By the time it was released as open source in 2024, we had already developed significant portions of the Perforator project, so we believe our work, particularly features like sPGO profiles, can provide additional value to the ecosystem.

We look forward to participating in the discussions and sharing our experiences with continuous profiling to contribute to the community's efforts.

@aalexand
Copy link

aalexand commented Feb 2, 2025

The profiler implementation is one thing, it would also be great to have you a part of the OTel profiling proto discussions and make sure that your learnings are taken into account.

@felixge
Copy link
Author

felixge commented Mar 20, 2025

We look forward to participating in the discussions and sharing our experiences with continuous profiling to contribute to the community's efforts.

We recently discussed your protobuf format, but realized it would be much more productive if we could ask questions to the people who worked on it. How is your availability to join one of upcoming meetings in the near future?

@itrofimow
Copy link

We'd be happy to join the discussion @felixge , and we should have someone available at the times profiling meeting takes place

Are there any specific questions you would like to be discussed?

@felixge
Copy link
Author

felixge commented Mar 24, 2025

Are there any specific questions you would like to be discussed?

We are very interested in any kind of quantitive analysis between your profiling format and pprof when it comes to data sizes and encoding/decoding efficiency.

In your article you mention the problem of pprof labels breaking the per-stack trace aggregation. We agree that this is an issue, and have addressed it the OpenTelemetry format by referencing stack traces from a lookup table. However, your format seems to have taken a much more radical approach of encoding everything in a column oriented fashion as well. We're very interested in learning more about the motivation for this, and what benefits you have observed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants