feat: add new popup menu icon #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new popup menu icon and refactors how clipboard button and popover content are integrated into UI components. Key changes include:
- Adding a ClipboardButton to the GroupId column in StorageGroups.
- Refactoring TenantNameWrapper and NodeHostWrapper to remove the CellWithPopover and instead integrate popover content directly through the EntityStatus component.
- Updating EntityStatus to support an optional infoPopoverContent and adjust the visibility logic for its controls.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/containers/Storage/StorageGroups/columns/columns.tsx | Adds a ClipboardButton and adjusts the column width for the GroupId column. |
| src/components/TenantNameWrapper/TenantNameWrapper.tsx | Removes CellWithPopover and introduces infoPopoverContent for displaying additional tenant links. |
| src/components/NodeHostWrapper/NodeHostWrapper.tsx | Removes CellWithPopover usage and supplies popover content directly to EntityStatus. |
| src/components/EntityStatus/EntityStatus.tsx | Integrates infoPopoverContent prop and updates control visibility logic for clipboard and info buttons. |
Files not reviewed (2)
- src/components/EntityStatus/EntityStatus.scss: Language not supported
- src/containers/Storage/StorageGroups/columns/StorageGroupsColumns.scss: Language not supported
Raubzeug
requested changes
Mar 27, 2025
| <InternalLink className={b('group-id')} to={getStorageGroupPath(row.GroupId)}> | ||
| {row.GroupId} | ||
| </InternalLink> | ||
| <ClipboardButton |
There was a problem hiding this comment.
Clipboard button is hidden if column is narrow enough.
Also, ellipsis for groupId is missed.
| visible: clipboardButtonAlwaysVisible, | ||
| })} | ||
| /> | ||
| {infoPopoverContent && ( |
There was a problem hiding this comment.
Info button always take place in column. It looks not good if column is narrow enough.
|
@Raubzeug fixed |
Raubzeug
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1977
Stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: ✅
Current: 83.25 MB | Main: 83.24 MB
Diff: +3.75 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information