Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whole tablet family for tabletPage #2054

Merged
merged 3 commits into from
Mar 27, 2025
Merged

fix: whole tablet family for tabletPage #2054

merged 3 commits into from
Mar 27, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Mar 27, 2025

Closes #2053

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
286 285 0 0 1
Test Changes Summary ⏭️1

⏭️ Skipped Tests (1)

  1. Streaming query shows some results and banner when stop button is clicked (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 83.24 MB | Main: 83.24 MB
Diff: +0.97 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements updates to the tablet family by changing the tablet API call, adjusting data filtering, and updating UI components related to tablets. Key changes include:

  • Passing an additional followerId parameter in the tablet API call and updating its filter.
  • Removing local filtering for non-dead tablet states in favor of server-side filtering.
  • Updating tablet-related components to support dynamically generated tablet page paths and include a new database parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/store/reducers/tablet.ts Updated tablet reducer to iterate over all history items, relying on API filtering.
src/services/api/viewer.ts Updated the getTablet API filter to include followerId and non-dead state checks.
src/containers/Tablet/components/TabletTable/TabletTable.tsx Modified column rendering to link to tablet pages and adjusted column naming.
src/containers/Tablet/Tablet.tsx Propagated the new database parameter through tablet components.
Comments suppressed due to low confidence (2)

src/store/reducers/tablet.ts:48

  • Removing the condition 'if (State !== 'Dead')' may lead to processing dead tablet states if the API filter ever changes. Confirm that the API consistently filters out dead tablets to avoid unintended data processing.
                        });

src/services/api/viewer.ts:291

  • Using a fallback value of 0 for followerId may not accurately represent an absent follower. Consider whether omitting the parameter or using a null value would be more appropriate based on API expectations.
                filter: `(TabletId=${id};FollowerId=${followerId || 0};State!=Dead)`,

Raubzeug
Raubzeug previously approved these changes Mar 27, 2025
@astandrik astandrik added this pull request to the merge queue Mar 27, 2025
@astandrik astandrik removed this pull request from the merge queue due to a manual request Mar 27, 2025
@astandrik astandrik added this pull request to the merge queue Mar 27, 2025
Merged via the queue into main with commit 98bfb54 Mar 27, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2053 branch March 27, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: followerId for tabletPage
2 participants