Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream test in safari #2059

Merged
merged 3 commits into from
Mar 31, 2025
Merged

fix: stream test in safari #2059

merged 3 commits into from
Mar 31, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Mar 28, 2025

Closes #1989

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
286 285 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.25 MB | Main: 83.25 MB
Diff: 0.00 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik requested a review from Copilot March 28, 2025 13:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue with test execution in Safari by removing a browser-specific skip and introducing a style workaround to mitigate rendering problems when handling large arrays.

  • Removed the browserName parameter and skip logic for Safari
  • Injected a CSS style tag to hide specific table cells to support heavy responses
Comments suppressed due to low confidence (2)

tests/suites/tenant/queryEditor/queryEditor.test.ts:147

  • The 'browserName' parameter is no longer used after removing the skip logic. Consider removing it from the test function signature to avoid confusion.
page, browserName,

tests/suites/tenant/queryEditor/queryEditor.test.ts:154

  • [nitpick] Ensure that the CSS selector targets only the intended table cells. If the table structure changes, this broad selector might hide unintended elements.
content: '.ydb-query-result-sets-viewer__result tr td:nth-child(3n) { display: none; }',

@astandrik astandrik added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 74355a4 Mar 31, 2025
8 checks passed
@astandrik astandrik deleted the astandrik.1989 branch March 31, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: stream test in safari
2 participants