-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PDiskSpaceDistribution): use only space severity for slots #2070
fix(PDiskSpaceDistribution): use only space severity for slots #2070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the severity calculation for VDisk slots in PDiskSpaceDistribution by using only the allocated space percent for severity, ignoring other VDisk statuses.
- Updated the severity logic in src/store/reducers/pdisk/utils.ts to remove combination with other status values.
- Adjusted tests in tests/preparePDiskDataResponse.test.ts to verify the new behavior and added an extra test to ensure VDisk statuses are ignored.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/store/reducers/pdisk/utils.ts | Updated severity calculation logic and comments to use only space severity for VDisks. |
src/store/reducers/pdisk/tests/preparePDiskDataResponse.test.ts | Updated and added tests to align with the new severity calculation for VDisk slots. |
68f6288
to
443151b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the severity computation for vDisk slots in PDiskSpaceDistribution by using only the space allocation percentage.
- Removed the combined severity calculation in favor of using getSpaceSeverity exclusively for vDisk slots.
- Updated tests to verify that vDisk severity is determined solely by allocated space.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/store/reducers/pdisk/utils.ts | Updated vDisk severity calculation to rely solely on allocated space. |
src/store/reducers/pdisk/tests/preparePDiskDataResponse.test.ts | Adjusted tests to reflect the new severity logic for vDisk slots. |
Closes #2060
New logic:
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.25 MB | Main: 83.25 MB
Diff: +0.09 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information