Skip to content

Commit 8c68412

Browse files
shnikdshnikd
authored
Merge 4ad4b42 into 6c442ab 
2 parents 6c442ab + 4ad4b42 commit 8c68412

15 files changed

+302
-92
lines changed

‎ydb/core/kqp/executer_actor/kqp_table_resolver.cpp

+9-3
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44
#include <ydb/core/base/cputime.h>
55
#include <ydb/core/base/path.h>
66
#include <ydb/core/kqp/executer_actor/kqp_executer.h>
7+
#include <ydb/core/sys_view/common/schema.h>
78
#include <ydb/library/actors/core/actor_bootstrapped.h>
89

9-
10-
1110
namespace NKikimr::NKqp {
1211

1312
using namespace NActors;
@@ -35,7 +34,8 @@ class TKqpTableResolver : public TActorBootstrapped<TKqpTableResolver> {
3534
, TxId(txId)
3635
, UserToken(userToken)
3736
, Transactions(transactions)
38-
, TasksGraph(tasksGraph) {}
37+
, TasksGraph(tasksGraph)
38+
, ShowCreateResolver(NSysView::CreateShowCreateResolver()) {}
3939

4040
void Bootstrap() {
4141
ResolveKeys();
@@ -173,6 +173,10 @@ class TKqpTableResolver : public TActorBootstrapped<TKqpTableResolver> {
173173

174174
stageInfo.Meta.ShardKey = ExtractKey(stageInfo.Meta.TableId, stageInfo.Meta.TableConstInfo, operation);
175175

176+
if (ShowCreateResolver->IsSystemView(stageInfo.Meta.TableId.SysViewInfo)) {
177+
continue;
178+
}
179+
176180
if (stageInfo.Meta.TableKind == ETableKind::Olap) {
177181
if (TableRequestIds.find(stageInfo.Meta.TableId) == TableRequestIds.end()) {
178182
auto& entry = requestNavigate->ResultSet.emplace_back();
@@ -276,6 +280,8 @@ class TKqpTableResolver : public TActorBootstrapped<TKqpTableResolver> {
276280
bool ShouldTerminate = false;
277281
TMaybe<ui32> GotUnexpectedEvent;
278282
TDuration CpuTime;
283+
284+
THolder<NSysView::ISystemViewResolver> ShowCreateResolver;
279285
};
280286

281287
} // anonymous namespace

‎ydb/core/kqp/executer_actor/ya.make

+4-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ SRCS(
1818
)
1919

2020
PEERDIR(
21-
ydb/library/actors/core
2221
library/cpp/containers/absl_flat_hash
2322
ydb/core/actorlib_impl
2423
ydb/core/base
@@ -28,20 +27,22 @@ PEERDIR(
2827
ydb/core/kqp/compute_actor
2928
ydb/core/kqp/executer_actor/shards_resolver
3029
ydb/core/kqp/federated_query
30+
ydb/core/kqp/gateway/local_rpc
3131
ydb/core/kqp/query_compiler
3232
ydb/core/kqp/rm_service
3333
ydb/core/kqp/topics
34-
ydb/core/kqp/gateway/local_rpc
3534
ydb/core/protos
35+
ydb/core/sys_view/common
3636
ydb/core/tx/long_tx_service/public
3737
ydb/core/ydb_convert
38-
ydb/services/metadata/abstract
38+
ydb/library/actors/core
3939
ydb/library/mkql_proto
4040
ydb/library/mkql_proto/protos
4141
ydb/library/yql/dq/actors/compute
4242
ydb/library/yql/dq/runtime
4343
ydb/library/yql/dq/tasks
4444
ydb/library/yql/providers/common/http_gateway
45+
ydb/services/metadata/abstract
4546
)
4647

4748
GENERATE_ENUM_SERIALIZATION(

‎ydb/core/kqp/gateway/kqp_metadata_loader.cpp

+24-2
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,20 @@ void TKqpTableMetadataLoader::OnLoadedTableMetadata(TTableMetadataResult& loadTa
573573
}
574574
}
575575

576+
NThreading::TFuture<NYql::IKikimrGateway::TTableMetadataResult> TKqpTableMetadataLoader::LoadShowCreateMetadata(
577+
const NSysView::ISystemViewResolver::TSystemViewPath& showCreatePath, const TString& cluster, const TString& table
578+
) {
579+
TNavigate::TEntry entry;
580+
581+
auto schema = ShowCreateResolver->GetSystemViewSchema(showCreatePath.ViewName, NSysView::ISystemViewResolver::ETarget::Domain);
582+
entry.Kind = TNavigate::KindTable;
583+
entry.Columns = std::move(schema->Columns);
584+
entry.TableId = TTableId(TSysTables::SysSchemeShard, 0, showCreatePath.ViewName);
585+
586+
auto result = GetTableMetadataResult(entry, cluster, table);
587+
588+
return MakeFuture(result);
589+
}
576590

577591
NThreading::TFuture<TTableMetadataResult> TKqpTableMetadataLoader::LoadTableMetadata(const TString& cluster, const TString& table,
578592
const NYql::IKikimrGateway::TLoadTableMetadataSettings& settings, const TString& database,
@@ -582,7 +596,14 @@ NThreading::TFuture<TTableMetadataResult> TKqpTableMetadataLoader::LoadTableMeta
582596

583597
auto ptr = weak_from_base();
584598
try {
585-
auto tableMetaFuture = LoadTableMetadataCache(cluster, table, settings, database, userToken);
599+
NThreading::TFuture<TTableMetadataResult> tableMetaFuture;
600+
601+
NSysView::ISystemViewResolver::TSystemViewPath showCreatePath;
602+
if (settings.ShowCreate_ && ShowCreateResolver->IsSystemViewPath(SplitPath(table), showCreatePath)) {
603+
tableMetaFuture = LoadShowCreateMetadata(showCreatePath, cluster, table);
604+
} else {
605+
tableMetaFuture = LoadTableMetadataCache(cluster, table, settings, database, userToken);
606+
}
586607
return tableMetaFuture.Apply([ptr, database, userToken](const TFuture<TTableMetadataResult>& future) mutable {
587608
try {
588609
auto result = future.GetValue();
@@ -947,7 +968,8 @@ NThreading::TFuture<TTableMetadataResult> TKqpTableMetadataLoader::LoadTableMeta
947968
catch (yexception& e) {
948969
promise.SetValue(ResultFromException<TResult>(e));
949970
}
950-
});
971+
}
972+
);
951973

952974
// Create an apply for the future that will fetch table statistics and save it in the metadata
953975
// This method will only run if cost based optimization is enabled

‎ydb/core/kqp/gateway/kqp_metadata_loader.h

+9-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@
22

33
#include <ydb/core/kqp/common/simple/temp_tables.h>
44
#include <ydb/core/kqp/provider/yql_kikimr_gateway.h>
5+
#include <ydb/core/kqp/provider/yql_kikimr_settings.h>
56
#include <ydb/core/scheme/scheme_tabledefs.h>
7+
#include <ydb/core/sys_view/common/schema.h>
68
#include <ydb/core/tx/scheme_cache/scheme_cache.h>
7-
#include <ydb/core/kqp/provider/yql_kikimr_settings.h>
9+
810
#include <library/cpp/threading/future/core/future.h>
911

1012
#include <util/system/mutex.h>
@@ -29,6 +31,7 @@ class TKqpTableMetadataLoader : public NYql::IKikimrGateway::IKqpTableMetadataLo
2931
, ActorSystem(actorSystem)
3032
, Config(config)
3133
, TempTablesState(std::move(tempTablesState))
34+
, ShowCreateResolver(NSysView::CreateShowCreateResolver())
3235
{}
3336

3437
NThreading::TFuture<NYql::IKikimrGateway::TTableMetadataResult> LoadTableMetadata(
@@ -61,13 +64,18 @@ class TKqpTableMetadataLoader : public NYql::IKikimrGateway::IKqpTableMetadataLo
6164

6265
void OnLoadedTableMetadata(NYql::IKikimrGateway::TTableMetadataResult& loadTableMetadataResult);
6366

67+
NThreading::TFuture<NYql::IKikimrGateway::TTableMetadataResult> LoadShowCreateMetadata(
68+
const NSysView::ISystemViewResolver::TSystemViewPath& showCreatePath, const TString& cluster, const TString& table
69+
);
70+
6471
const TString Cluster;
6572
TVector<NKikimrKqp::TKqpTableMetadataProto> CollectedSchemeData;
6673
TMutex Lock;
6774
bool NeedCollectSchemeData;
6875
TActorSystem* ActorSystem;
6976
NYql::TKikimrConfiguration::TPtr Config;
7077
TKqpTempTablesState::TConstPtr TempTablesState;
78+
THolder<NSysView::ISystemViewResolver> ShowCreateResolver;
7179
};
7280

7381
} // namespace NKikimr::NKqp

‎ydb/core/kqp/gateway/ya.make

+7-6
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,22 @@ SRCS(
77
)
88

99
PEERDIR(
10-
ydb/library/actors/core
1110
ydb/core/actorlib_impl
1211
ydb/core/base
1312
ydb/core/kqp/common
14-
ydb/core/kqp/provider
15-
ydb/core/kqp/query_data
1613
ydb/core/kqp/gateway/actors
17-
ydb/core/kqp/gateway/behaviour/tablestore
18-
ydb/core/kqp/gateway/behaviour/table
1914
ydb/core/kqp/gateway/behaviour/external_data_source
2015
ydb/core/kqp/gateway/behaviour/resource_pool
2116
ydb/core/kqp/gateway/behaviour/resource_pool_classifier
17+
ydb/core/kqp/gateway/behaviour/table
18+
ydb/core/kqp/gateway/behaviour/tablestore
2219
ydb/core/kqp/gateway/behaviour/view
2320
ydb/core/kqp/gateway/utils
24-
ydb/core/statistics/service
21+
ydb/core/kqp/provider
22+
ydb/core/kqp/query_data
23+
ydb/core/statistics/service
24+
ydb/core/sys_view/common
25+
ydb/library/actors/core
2526
yql/essentials/providers/result/expr_nodes
2627
)
2728

‎ydb/core/kqp/provider/yql_kikimr_datasource.cpp

+30-4
Original file line numberDiff line numberDiff line change
@@ -102,23 +102,48 @@ class TKiSourceIntentDeterminationTransformer: public TKiSourceVisitorTransforme
102102

103103
private:
104104
TStatus HandleKiRead(TKiReadBase node, TExprContext& ctx) override {
105+
bool showCreateTableRewritten = false;
106+
TExprBase currentNode(node);
107+
if (auto maybeReadTable = currentNode.Maybe<TKiReadTable>()) {
108+
auto readTable = maybeReadTable.Cast();
109+
for (auto setting : readTable.Settings()) {
110+
auto name = setting.Name().Value();
111+
if (name == "showCreateTableRewritten") {
112+
showCreateTableRewritten = true;
113+
}
114+
}
115+
}
116+
105117
auto cluster = node.DataSource().Cluster();
106118
TKikimrKey key(ctx);
107119
if (!key.Extract(node.TableKey().Ref())) {
108120
return TStatus::Error;
109121
}
110122

111-
return HandleKey(cluster, key);
123+
return HandleKey(cluster, key, showCreateTableRewritten);
112124
}
113125

114126
TStatus HandleRead(TExprBase node, TExprContext& ctx) override {
127+
bool showCreateTableRewritten = false;
128+
if (auto maybeRead = node.Maybe<TCoRead>()) {
129+
auto read = maybeRead.Cast();
130+
for (auto arg : read.FreeArgs()) {
131+
if (auto maybeTuple = arg.Maybe<TCoNameValueTuple>()) {
132+
auto tuple = maybeTuple.Cast();
133+
if (tuple.Ref().Child(0)->Content() == "showCreateTableRewritten") {
134+
showCreateTableRewritten = true;
135+
}
136+
}
137+
}
138+
}
139+
115140
auto cluster = node.Ref().Child(1)->Child(1)->Content();
116141
TKikimrKey key(ctx);
117142
if (!key.Extract(*node.Ref().Child(2))) {
118143
return TStatus::Error;
119144
}
120145

121-
return HandleKey(cluster, key);
146+
return HandleKey(cluster, key, showCreateTableRewritten);
122147
}
123148

124149
TStatus HandleLength(TExprBase node, TExprContext& ctx) override {
@@ -134,12 +159,12 @@ class TKiSourceIntentDeterminationTransformer: public TKiSourceVisitorTransforme
134159
}
135160

136161
private:
137-
TStatus HandleKey(const TStringBuf& cluster, const TKikimrKey& key) {
162+
TStatus HandleKey(const TStringBuf& cluster, const TKikimrKey& key, bool showCreate = false) {
138163
switch (key.GetKeyType()) {
139164
case TKikimrKey::Type::Table:
140165
case TKikimrKey::Type::TableScheme: {
141166
auto& table = SessionCtx->Tables().GetOrAddTable(TString(cluster), SessionCtx->GetDatabase(),
142-
key.GetTablePath());
167+
key.GetTablePath(), ETableType::Table, showCreate);
143168

144169
if (key.GetKeyType() == TKikimrKey::Type::TableScheme) {
145170
table.RequireStats();
@@ -238,6 +263,7 @@ class TKiSourceLoadTableMetadataTransformer : public TGraphTransformerBase {
238263
.WithAuthInfo(table.GetNeedAuthInfo())
239264
.WithExternalSourceFactory(ExternalSourceFactory)
240265
.WithReadAttributes(readAttrs ? std::move(*readAttrs) : THashMap<TString, TString>{})
266+
.WithShowCreate(table.GetShowCreate())
241267
);
242268

243269
futures.push_back(future.Apply([result, queryType]

‎ydb/core/kqp/provider/yql_kikimr_gateway.h

+6
Original file line numberDiff line numberDiff line change
@@ -1092,12 +1092,18 @@ class IKikimrGateway : public TThrRefBase {
10921092
return *this;
10931093
}
10941094

1095+
TLoadTableMetadataSettings& WithShowCreate(bool enable) {
1096+
ShowCreate_ = enable;
1097+
return *this;
1098+
}
1099+
10951100
NKikimr::NExternalSource::IExternalSourceFactory::TPtr ExternalSourceFactory;
10961101
THashMap<TString, TString> ReadAttributes;
10971102
bool RequestStats_ = false;
10981103
bool WithPrivateTables_ = false;
10991104
bool WithExternalDatasources_ = false;
11001105
bool RequestAuthInfo_ = true;
1106+
bool ShowCreate_ = false;
11011107
};
11021108

11031109
class IKqpTableMetadataLoader : public std::enable_shared_from_this<IKqpTableMetadataLoader> {

‎ydb/core/kqp/provider/yql_kikimr_opt_build.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -974,7 +974,7 @@ TExprNode::TPtr KiBuildQuery(TExprBase node, TExprContext& ctx, TStringBuf datab
974974

975975
auto showCreateValue = Build<TCoNameValueTuple>(ctx, node.Pos())
976976
.Name()
977-
.Build("showCreateTable")
977+
.Build("showCreateTableRewritten")
978978
.Value<TCoAtom>()
979979
.Value(key.GetTablePath())
980980
.Build()
@@ -1012,7 +1012,7 @@ TExprNode::TPtr KiBuildQuery(TExprBase node, TExprContext& ctx, TStringBuf datab
10121012
for (auto arg : read.FreeArgs()) {
10131013
if (auto tuple = arg.Maybe<TCoNameValueTuple>()) {
10141014
auto name = tuple.Cast().Name().Value();
1015-
if (name == "showCreateTable") {
1015+
if (name == "showCreateTableRewritten") {
10161016
showCreateTableRightReplaces[input.Get()] = nullptr;
10171017
}
10181018
}
@@ -1030,7 +1030,7 @@ TExprNode::TPtr KiBuildQuery(TExprBase node, TExprContext& ctx, TStringBuf datab
10301030
for (auto arg : read.FreeArgs()) {
10311031
if (auto tuple = arg.Maybe<TCoNameValueTuple>()) {
10321032
auto name = tuple.Cast().Name().Value();
1033-
if (name == "showCreateTable") {
1033+
if (name == "showCreateTableRewritten") {
10341034
tablePath = tuple.Cast().Value().Cast().Cast<TCoAtom>().StringValue();
10351035
}
10361036
}

‎ydb/core/kqp/provider/yql_kikimr_provider.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ const TKikimrTableDescription* TKikimrTablesData::EnsureTableExists(const TStrin
172172
return nullptr;
173173
}
174174

175-
TKikimrTableDescription& TKikimrTablesData::GetOrAddTable(const TString& cluster, const TString& database, const TString& table, ETableType tableType) {
175+
TKikimrTableDescription& TKikimrTablesData::GetOrAddTable(const TString& cluster, const TString& database,
176+
const TString& table, ETableType tableType, bool showCreate) {
176177
auto tablePath = table;
177178
if (TempTablesState) {
178179
auto tempTableInfoIt = TempTablesState->FindInfo(table, true);
@@ -192,6 +193,8 @@ TKikimrTableDescription& TKikimrTablesData::GetOrAddTable(const TString& cluster
192193
}
193194
desc.SetTableType(tableType);
194195

196+
desc.SetShowCreate(showCreate);
197+
195198
return desc;
196199
}
197200

‎ydb/core/kqp/provider/yql_kikimr_provider.h

+5-1
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,15 @@ class TKikimrTableDescription {
177177
ETableType GetTableType() const { return TableType; }
178178
void SetTableType(ETableType tableType) { TableType = tableType; }
179179

180+
void SetShowCreate(bool flag) { ShowCreate = flag; }
181+
bool GetShowCreate() const { return ShowCreate; }
182+
180183
private:
181184
THashMap<TString, const TTypeAnnotationNode*> ColumnTypes;
182185
bool NeedsStats = false;
183186
bool NeedAuthInfo = true;
184187
ETableType TableType;
188+
bool ShowCreate = false;
185189
};
186190

187191
class TKikimrTablesData : public TThrRefBase {
@@ -191,7 +195,7 @@ class TKikimrTablesData : public TThrRefBase {
191195
TKikimrTablesData& operator=(const TKikimrTablesData&) = delete;
192196

193197
TKikimrTableDescription& GetOrAddTable(const TString& cluster, const TString& database, const TString& table,
194-
ETableType tableType = ETableType::Table);
198+
ETableType tableType = ETableType::Table, bool showCreate = false);
195199
TKikimrTableDescription& GetTable(const TString& cluster, const TString& table);
196200

197201
const TKikimrTableDescription* EnsureTableExists(const TString& cluster, const TString& table,

0 commit comments

Comments
 (0)