Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update to enable CodeSniffer v3 #34

Closed
axtho opened this issue May 11, 2017 · 11 comments
Closed

Please update to enable CodeSniffer v3 #34

axtho opened this issue May 11, 2017 · 11 comments

Comments

@axtho
Copy link

axtho commented May 11, 2017

Currently it breaks your implementation:

HP Fatal error: Interface 'PHP_CodeSniffer_Sniff' not found in ./vendor/yiisoft/yii2-coding-standards/Yii2/Sniffs/Files/SpacesAroundConcatSniff.php on line 13

https://github.com/squizlabs/PHP_CodeSniffer/wiki/Version-3.0-Upgrade-Guide
Maybe up that to another version so that the v2.x implementations of CodeSniffer still work?

@krukru
Copy link
Contributor

krukru commented May 11, 2017

I have an open PR #32 that addresses this issue.
For now (until the code gets migrated) I think it would be best to clamp the version in composer.json to "squizlabs/php_codesniffer": ">=2.3.1 <3.0"

@davidmpaz
Copy link

What is the status of this? Is the PR merged?

@samdark
Copy link
Member

samdark commented Jan 7, 2018

No. It is not. The version is fixed so codesniffer can't update to v3.

@davidmpaz
Copy link

Got it. Thanks

@biaoqianwo
Copy link

I hope Official to upgrade to support PHPCodeSniffer v3 too.

@urosgruber
Copy link

Can this get merged or project is not maintained anymore?

@samdark
Copy link
Member

samdark commented Aug 3, 2018

@urosgruber the pull request is w/ issues so wasn't merged. Do you want to fix it and test it properly? Then we'll merge.

@urosgruber
Copy link

I was asking because we're looking to use Codeclimate integration. It's still only for v2 mostly because of plugins not being upgraded to v3. Also I'm on Symfony so I would spend to much time properly fixing this plugin and testing it as I'm not familiar with yii framework.

@samdark
Copy link
Member

samdark commented Aug 6, 2018

Well, can't merge a solution with known issues.

@urosgruber
Copy link

I understand. Just needed confirmation about the status of this so we know how to proceed

@samdark
Copy link
Member

samdark commented Sep 4, 2018

#37

@samdark samdark closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants