Fix cider-eval-pprint-with-multiline-comment-handler

The printed value is in the value slot, not the out or err slots. Accumulate the
result in the value handler and insert the actual comment in the done handler.

Author: cichli

Diff for: .dir-locals.el

@@ -22,7 +22,6 @@
                               (cider--jack-in . 1)
                               (cider--make-result-overlay . 1)
                               ;; need better solution for indenting cl-flet bindings
-                              (multiline-comment-handler . defun) ;; cl-flet
                               (insert-label . defun)              ;; cl-flet
                               (insert-align-label . defun)        ;; cl-flet
                               (insert-rect . defun)               ;; cl-flet

Diff for: CHANGELOG.md

@@ -26,6 +26,7 @@
 * `cider-ns-save-files-on-refresh` will now save any modified buffers visiting files on the classpath, rather than just in the current project.
 * `cider-expected-ns` no longer requires an absolute path as its argument, and now internally handles paths canonically and consistently.
 * Fixed a bug causing REPL output to be inserted after the prompt.
+* Fixed a bug causing `cider-pprint-eval-last-sexp-to-comment` and `cider-pprint-eval-defun-to-comment` to not insert anything.
 
 ## 0.20.0 (2019-01-14)
 

Diff for: cider-eval.el

@@ -544,22 +544,28 @@ LOCATION is the location at which to insert.
 COMMENT-PREFIX is the comment prefix for the first line of output.
 CONTINUED-PREFIX is the comment prefix to use for the remaining lines.
 COMMENT-POSTFIX is the text to output after the last line."
-  (cl-flet ((multiline-comment-handler (buffer value)
-              (with-current-buffer buffer
-                (save-excursion
-                  (goto-char location)
-                  (let ((lines (split-string value "[\n]+" t)))
-                    ;; only the first line gets the normal comment-prefix
-                    (insert (concat comment-prefix (pop lines)))
-                    (dolist (elem lines)
-                      (insert (concat "\n" continued-prefix elem)))
-                    (unless (string= comment-postfix "")
-                      (insert comment-postfix)))))))
-    (nrepl-make-response-handler buffer
-                                 '()
-                                 #'multiline-comment-handler
-                                 #'multiline-comment-handler
-                                 '())))
+  (let ((res ""))
+    (nrepl-make-response-handler
+     buffer
+     (lambda (_buffer value)
+       (setq res (concat res value)))
+     nil
+     nil
+     (lambda (buffer)
+       (with-current-buffer buffer
+         (save-excursion
+           (goto-char location)
+           (let ((lines (split-string res "[\n]+" t)))
+             ;; only the first line gets the normal comment-prefix
+             (insert (concat comment-prefix (pop lines)))
+             (dolist (elem lines)
+               (insert (concat "\n" continued-prefix elem)))
+             (unless (string= comment-postfix "")
+               (insert comment-postfix))))))
+     nil
+     nil
+     (lambda (_buffer warning)
+       (setq res (concat res warning))))))
 
 (defun cider-popup-eval-handler (&optional buffer)
   "Make a handler for printing evaluation results in popup BUFFER.