Skip to content

Commit e325b76

Browse files
committed
Removing Request as a dependency
1 parent 8c6bb4a commit e325b76

7 files changed

+6273
-60225
lines changed

Diff for: bin/z-schema

+17-17
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ process.exitCode = 0;
66
var fs = require("fs");
77
var path = require("path");
88
var program = require("commander");
9-
var request = require("request");
9+
var request = require("https").request;
1010
var package = require("./../package.json");
1111
var ZSchema = require("./../src/ZSchema");
1212

@@ -92,26 +92,26 @@ function validateWithAutomaticDownloads(filePath, data, schema, callback) {
9292
if (missingReferences.length > 0) {
9393
var finished = 0;
9494
missingReferences.forEach(function (url) {
95-
96-
if (url.match(/^https?:/)) {
97-
request(url, function (error, response, body) {
95+
var urlString = "request: " + url + " - ";
9896

99-
var urlString = "request: " + url + " - ";
97+
if (url.match(/^https?:/)) {
98+
request(url, function (response) {
99+
var body = "";
100+
response.on("data", function (chunk) { data += chunk; });
101+
response.on("end", function () {
100102

101-
if (error) {
102-
if (response) { console.error(urlString + response.statusCode); }
103-
console.error(error);
104-
process.exit(1);
105-
} else {
106103
console.log(urlString + response.statusCode);
107-
}
108-
109-
validator.setRemoteReference(url, JSON.parse(body));
110-
finished++;
111-
if (finished === missingReferences.length) {
112-
validate();
113-
}
114104

105+
validator.setRemoteReference(url, JSON.parse(body));
106+
finished++;
107+
if (finished === missingReferences.length) {
108+
validate();
109+
}
110+
});
111+
}).on("error", function (error) {
112+
console.error(urlString);
113+
console.error(error);
114+
process.exit(1);
115115
});
116116
} else {
117117
// FUTURE: maybe else if (isFile(url)) later

Diff for: dist/ZSchema-browser-min.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: dist/ZSchema-browser-min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)