v0.0.5 add replace Host on header

Add test for host change

add replace host header

Author: zxcabs

lib/ProxyServer.js

@@ -41,18 +41,22 @@ function ProxyServer(opt) {
 ProxyServer.prototype.__requestListener = function __requestListener(client) {
 	var self = this,
 		parser = parsers(onMessageComplete),
-		hash = tools.getHash(),
 		chunks = [];
 
 	function clear() {
 		client.removeListener('data', onClientData);
 	}
 
 	function onMessageComplete  () {
-		var data = {
-				raw: Buffer.concat(chunks),
-				hash: hash.end()
-			};
+		var data,
+			raw = Buffer.concat(chunks);
+
+		raw = self.__addHost(raw);
+
+		data = {
+			raw: raw,
+			hash: tools.getHash().update(raw).end()
+		};
 
 		clear();
 
@@ -62,11 +66,8 @@ ProxyServer.prototype.__requestListener = function __requestListener(client) {
 	}
 
 	function onClientData(chunk) {
-		process.nextTick(function () {
-			parser.execute(chunk, 0, chunk.length);
-		});
-		hash.update(chunk);
 		chunks.push(chunk);
+		parser.execute(chunk, 0, chunk.length);
 	}
 
 	client.on('data',onClientData);
@@ -127,6 +128,23 @@ ProxyServer.prototype.reset = function reset() {
 	}
 };
 
+ProxyServer.prototype.__addHost = function addHost(raw) {
+	var index = tools.getEndHeaderIndex(raw),
+		lns = raw.slice(0, index).toString('utf8').split('\r\n'),
+		i, l;
+
+	for (i = 1, l = lns.length; l > i; i += 1) {
+		if (!/^Host:/.test(lns[i])) continue;
+        lns[i] = 'Host: ' + this.dest.host + ':' + this.dest.port;
+		break;
+	}
+
+	lns = lns.join('\r\n');
+	raw = Buffer.concat([new Buffer(lns), raw.slice(index)]);
+
+	return raw;
+};
+
 //plugins
 ProxyServer.plugins = {
 	replaceParamsInHash: require('./plugins/replaceParamsInHash.js')

lib/tools.js

@@ -28,3 +28,22 @@ MD5.prototype.end = function end() {
 exports.getHash = function getHash() {
 	return new MD5();
 };
+
+
+var R = 13, // \r
+	N = 10; // \n
+/**
+ * Return last header index from buffer
+ *
+ * @param {Buffer} buff Raw data
+ * @return {Integer} Index
+ */
+exports.getEndHeaderIndex = function getEndHeaderIndex(buff) {
+	var i, l;
+
+	for (i = 0, l = buff.length - 4; l > i; i += 1) {
+		if (buff[i] === R && buff[i + 4] === N) break;
+	}
+
+	return i;
+};

package.json

@@ -1,7 +1,7 @@
 {
 	"name": "node-http-proxy-cache",
 	"description": "Http caching proxy for the development clients to different websites and api",
-	"version": "0.0.4",
+	"version": "0.0.5",
 	"author": "Evgeny Reznichenko <[email protected]>",
 	"dependencies": {
 		"async": "0.2.8"

test/proxyServer.js

@@ -69,11 +69,13 @@ describe('ProxyServer', function () {
 	 * Test for proxy
 	 */
 	describe('proxy', function () {
-		var server, requestCount, proxy;
+		var server, requestCount, proxy,
+			lastRequestHeaders;
 
 		requestCount = 0;
 		server = http.createServer(function (req, res) {
 			requestCount += 1;
+			lastRequestHeaders = req.headers;
 			res.writeHead(200, { 'Content-Type': 'text/plain' });
 			res.end('Hello');
 		});
@@ -99,6 +101,7 @@ describe('ProxyServer', function () {
 		beforeEach(function () {
 			proxy.reset();
 			requestCount = 0;
+			lastRequestHeaders = null;
 		});
 
 
@@ -121,6 +124,16 @@ describe('ProxyServer', function () {
 
 			makeReq(makeReq(done))();
 		});
+
+		it('should change host', function (done) {
+			req
+				.get('localhost:' + LOCAL_PROXY_PORT)
+				.end(function (err, res) {
+					should.not.exist(err);
+					lastRequestHeaders.should.have.property('host', proxy.dest.host + ':' + proxy.dest.port);
+					done();
+				});
+		});
 	});
 
 	/**

test/tools.js

@@ -32,4 +32,17 @@ describe('tools', function () {
 		});
 
 	});
+
+	/**
+	 * Test for #getEndHeaderIndex
+	 */
+	describe('#getEndHeaderIndex', function () {
+		var raw = new Buffer('GET / HTTP/1.1\r\nHost: localhost\r\n\r\n'),
+			last = raw.length - 4;
+
+		it('should return ' + last, function () {
+			var index = tools.getEndHeaderIndex(raw);
+			index.should.eql(last);
+		});
+	});
 });