Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to resolve users and parents #116

Merged
merged 29 commits into from
Jun 16, 2023
Merged

Conversation

johguentner
Copy link
Member

  • some entities have parents or expose user-ids, without additional information
  • by resolving these within the "endpoint" (not a real notion enpoint) Resolve::class, the additional information can be easily obtained

johguentner and others added 2 commits February 6, 2023 16:06
- some entities have parents or expose user-ids, without additional information
- by resolving these within the "endpoint" (not a real notion enpoint) ``Resolve::class``, the additional information can be easily obtained
@johguentner johguentner added this to the 🍵 v1.1.0 milestone Feb 6, 2023
@johguentner johguentner changed the base branch from main to dev February 6, 2023 15:08
@what-the-diff
Copy link

what-the-diff bot commented Feb 6, 2023

  • Added a new endpoint for comments
  • Added the ability to resolve users, pages and databases from notion parents (e.g.: blocks)
  • Add timestamps, archive status and parent information to block entities
  • Add comment entity with collection class
  • Added HasTimestamps, HasArchive and HasParent traits to Database entity
  • Removed createdTime and lastEditedTime properties from Database entity
  • Moved fillId() method from Entity class to NotionParent class (which is a parent of all entities)
  • Renamed fillCreatedTime(), fillLastEditedTime() methods in Page, Block classes as they are now handled by the trait added in step 1 above
  • Changed signature of setResponseData(array $responseData): void method on PropertyItem interface so that it throws HandlingException instead of \InvalidArgumentException exception when invalid data is passed into it
  • Added comments endpoint
  • Added resolve endpoint
  • Refactored blocks to use new traits for timestamps, parent and archive attributes
  • Added new properties to Database entity
  • Added new property to Page entity
  • Fixed typo in User Entity (object_type)
  • Updated specific block response with archived and parent data, added paragraph test text
  • Created comments endpoints tests for create comment and list comments: 403 error responses, 404 error responses, 200 success responses

Copy link
Member

@mechelon mechelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For v1.1.0 👍

@johguentner johguentner marked this pull request as draft February 16, 2023 12:45
@johguentner johguentner marked this pull request as ready for review April 30, 2023 13:42
@johguentner johguentner added the enhancement New feature or request label Apr 30, 2023
@johguentner johguentner self-assigned this Apr 30, 2023
@johguentner johguentner requested a review from mechelon June 9, 2023 17:01
@johguentner
Copy link
Member Author

@mechelon: Regarding review - you don't have to check all files (most of the changes come from other open PRs); Please check the tests and the according Notion workspace. If you need anything, please let me know :)

@johguentner johguentner merged commit 07a320e into dev Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants