Snapshot and Fake Tests Later #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- load `NOTION_API_TOKEN` - important for later tests
- allows to register the `Http` macro `recordAndFakeLater` - this allows to create records for http requests, which will be stored and faked later to avoid calling API endpoints
- if the service is running in the console
- which has similar functionality as previous, however tests with the new `Http::recordAndFakeLater` macro
- for comments endpoint
- http macro
|
- change `plugin` to `macro`, because it is a more accurate definition
- .env.testing is only required during local tests, especially for creating new snapshots, on ci it is not required
- from `__recorded__` to `snapshots`
johguentner
changed the title
mechelon
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the help of the
PestHttpRecorder::classandHttpRecorder::class, all external requests (done with theHttpFacade) during testing, will be intercepted, saved as snapshot and faked for the same requests for future tests.This is increases the validity of all snapshots, which fake requests during testing (important for fast tests and testing within CI).
If new tests are written, the snapshots will we generated locally automatically. After breaking changes of the Notion API, the generation of the snapshots can be forced, to keep validity of tests at a high level.