Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix null error during creation of NotionException #133

Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix null error during creation of NotionException #133

merged 1 commit into from
Apr 21, 2023

Conversation

johguentner
Copy link
Member

@johguentner johguentner commented Apr 21, 2023 •
edited
Loading

  • replace array_key_exists with Arr::exists(...)
  • if $responseBody == null, insert empty array

@johguentner
fix null error during creation of NotionException
d670a64 
- replace `array_key_exists` with `Arr::exists(...)`
- if `$responseBody` == null, insert empty array
@what-the-diff
Copy link

what-the-diff bot commented Apr 21, 2023

PR Summary

  • Improved array key checks
    Replaced the array_key_exists function with the more efficient Arr::exists method for better performance.

@johguentner johguentner self-assigned this Apr 21, 2023
@johguentner johguentner mentioned this pull request Apr 21, 2023
Closed
@johguentner
Copy link
Member Author

Fixes #132

@johguentner johguentner merged commit 4d5e556 into main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johguentner johguentner

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johguentner