Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #138

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Apply fixes from StyleCI #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/EndpointBlocksTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ public function classProvider(): array

/**
* @test
*
* @dataProvider classProvider
*
* @param $entityClass
Expand Down
2 changes: 0 additions & 2 deletions tests/EndpointCommentsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
});

it('should fetch list of comments with an accurate representation of attributes', function () {

// successfull /v1/comments
Http::fake([
'https://api.notion.com/v1/comments?block_id=abf6b0af-6eaa-45ca-9715-9fa147ef6b17*' => Http::response(
Expand Down Expand Up @@ -114,7 +113,6 @@
});

it('successfully creates a comment within a page', function () {

// successfull (post) /v1/comments
Http::fake([
'https://api.notion.com/v1/comments*' => Http::response(
Expand Down
4 changes: 1 addition & 3 deletions tests/EndpointDatabaseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
* @see https://developers.notion.com/reference/post-database-query
*/
it('returns a database endpoint instance', function () {

// TODO update for new Filter behaviour
// TODO update for new Filter behaviour
$endpoint = Notion::database('897e5a76ae524b489fdfe71f5945d1af');

$this->assertInstanceOf(Database::class, $endpoint);
Expand Down Expand Up @@ -136,7 +135,6 @@
});

it('throws a notion exception for a bad request', function () {

// failing /v1/databases
Http::fake([
'https://api.notion.com/v1/databases/8284f3ff77e24d4a939d19459e4d6bdc/query*' => Http::response(
Expand Down
1 change: 0 additions & 1 deletion tests/EndpointPagesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ public function it_throws_a_notion_exception_not_found()
/** @test */
public function it_assembles_properties_for_a_new_page()
{

// test values
$pageId = '0349b883a1c64539b435289ea62b6eab';
$pageTitle = 'I was updated from Tinkerwell';
Expand Down
1 change: 0 additions & 1 deletion tests/FilterBagTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@
});

it('creates a filter bag with with the AND operator and a nested OR condition', function () {

// Filter for all entries that are
// (KnownFor == Univac && (Name == Grace || Name == Jean))

Expand Down