Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast startCursor to string #48

Closed
wants to merge 4 commits into from
Closed

Conversation

keithbrink
Copy link

Without a cast, it will be sent as an object and Notion will return a 400 error:

Bad Request: (validation_error) (body failed validation: body.start_cursor should be a string or `undefined`, instead was `{}`.)  

Without a cast, it will be sent as an object and Notion will return a 400 error:

```
Bad Request: (validation_error) (body failed validation: body.start_cursor should be a string or `undefined`, instead was `{}`.)  
```
@LeeGellie417
Copy link

Any updates on this? I'm still facing the exact same issue with v0.7.0.

@johguentner
Copy link
Member

Thank you @keithbrink for your contribution!

Even though this is a fix, we want to make sure to cover all PRs (especially breaking-changes) with additional tests, therefore I'm going to close this.

This PR #73 will provide improvements for the pagination and will fix this issue as well. We release it, as soon as we have implemented tests, docs and release notes for v0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants