Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relation property mapping #96

Merged
merged 1 commit into from
Jan 27, 2023
Merged

add relation property mapping #96

merged 1 commit into from
Jan 27, 2023

Conversation

Gummibeer
Copy link
Contributor

Right now the relation property is missing from the mapping - but the class exists and is working.

@what-the-diff
Copy link

what-the-diff bot commented Jan 26, 2023

  • Added a new case to the switch statement
  • The new case is for 'relation' type properties
  • This will map relation types to Relation class in PropertyFactory::mapTypeToClass() method

@johguentner johguentner changed the base branch from main to dev January 26, 2023 15:53
@johguentner johguentner self-assigned this Jan 26, 2023
@johguentner johguentner added this to the 🌳 v1.0.0 milestone Jan 26, 2023
@johguentner johguentner requested a review from mechelon January 26, 2023 16:52
@mechelon
Copy link
Member

You're absolutely right, thank you! We will merge this for the upcoming release.

@Gummibeer
Copy link
Contributor Author

It's tagged for v1.0.0 - will this be the next release? Or could you go for a v0.8.1 as it's a fix and I would need that one for a project I'm working on. No real deadline and right now I have adjusted it in vendor - but can't deploy without having a real release.

@johguentner johguentner removed this from the 🌳 v1.0.0 milestone Jan 27, 2023
@johguentner
Copy link
Member

It's tagged for v1.0.0 - will this be the next release? Or could you go for a v0.8.1 as it's a fix and I would need that one for a project I'm working on. No real deadline and right now I have adjusted it in vendor - but can't deploy without having a real release.

Thank you for point this out. I'll do a release right now.

@johguentner johguentner changed the base branch from dev to main January 27, 2023 15:27
@johguentner johguentner merged commit 1e259ff into 5am-code:main Jan 27, 2023
@Gummibeer Gummibeer deleted the patch-1 branch January 29, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants