Lmm/master #55
Closed
Lmm/master #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…poses another transaction fee
|
It looks like your indentation may be off. Check you "tab indent" settings in your text editor. It should be set to two spaces. (maybe you have already done this since you submitted this PR) |
| puts "Your balance was #{@balance}." | ||
|
|
||
| if @balance - withdraw_amount <= @min_balance | ||
| puts "Don't drop below 10 dollars w/ transaction fee." |
There was a problem hiding this comment.
It would be nice to use your @min_balance var in this string to ensure that if that variable was changed, the error message would also be chaqnged.
|
Nice job! I like the way you've used inheritance to centralize the code which is the same across the board |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waves 1-3 completed with all optionals.